From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 4/4] posix: Add posix_spawn_file_actions_closefrom
Date: Tue, 09 Mar 2021 21:00:48 +0100 [thread overview]
Message-ID: <87czw8yu4v.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <edbc1a66-df74-1854-b03b-65bdc413167f@linaro.org> (Adhemerval Zanella's message of "Tue, 9 Mar 2021 16:48:48 -0300")
* Adhemerval Zanella:
>> I believe the closefrom should start add lowfd here, to check that the
>> closing is ordered with regards to the other operations.
>
> It is already doing in, doesn't it? The {lowfd, lowfd+1} only exists
> if closefrom is ordered regarding addopen and adddup2.
Okay, fair enough. I would have expected that the closefrom call would
be in the middle of the action list.
>> If you implement the agressive up-to-INT_MAX closing in
>> __closefrom_fallback, this probably needs a flag that it disables it
>> when called from here.
>
> Ack, although I do not see much gain since it should be a fallback to
> a fallback.
Oh, I think we should fail if the open of /proc/self/fd fails. There is
no reason to try very hard to avoid process termination.
Thanks,
Florian
next prev parent reply other threads:[~2021-03-09 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 16:36 [PATCH v3 1/4] support: Add xclone Adhemerval Zanella
2020-12-23 16:36 ` [PATCH v3 2/4] Linux: Add close_range Adhemerval Zanella
2021-03-09 9:47 ` Florian Weimer
2021-03-09 10:02 ` Christian Brauner
2021-03-09 17:53 ` Adhemerval Zanella
2021-03-09 18:30 ` Florian Weimer
2020-12-23 16:36 ` [PATCH v3 3/4] io: Add closefrom [BZ #10353] Adhemerval Zanella
2021-03-09 10:23 ` Florian Weimer
2021-03-09 19:07 ` Adhemerval Zanella
2020-12-23 16:36 ` [PATCH v3 4/4] posix: Add posix_spawn_file_actions_closefrom Adhemerval Zanella
2021-03-09 10:45 ` Florian Weimer
2021-03-09 19:48 ` Adhemerval Zanella
2021-03-09 20:00 ` Florian Weimer [this message]
2021-03-09 20:04 ` Adhemerval Zanella
2021-03-09 9:19 ` [PATCH v3 1/4] support: Add xclone Florian Weimer
2021-03-09 16:17 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czw8yu4v.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).