Re: [PATCH v2 03/10] Rename __LONG_DOUBLE_USES_FLOAT128 to

[Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>]

"Paul E. Murphy via Libc-alpha" <libc-alpha@sourceware.org> writes:

> __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI per feedback and disucssion

It seems the subject of the commit and the initial explanation got mixed up.

> diff --git a/bits/long-double.h b/bits/long-double.h
> index 6e16447e65..bdde78f49a 100644
> --- a/bits/long-double.h
> +++ b/bits/long-double.h
> @@ -37,4 +37,17 @@
>  #ifndef __NO_LONG_DOUBLE_MATH
>  # define __NO_LONG_DOUBLE_MATH	1
>  #endif
> -#define __LONG_DOUBLE_USES_FLOAT128 0
> +
> +/* The macro __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI is used to determine the
> +   choice of the underlying ABI of long double.  It will always assume
> +   a constant value for each translation unit.
> +
> +   If the value is non-zero, any API which is parameterized by the long
> +   double type (i.e the scanf/printf family of functions or the explicitly
> +   parameterized math.h functions) will be redirected to a compatible
> +   implementation using _Float128 ABI via symbols suffixed with ieee128.
> +
> +   The mechanism this macro uses to acquire may be a function
> +   of architecture, or target specific options used to invoke the
> +   compiler.  */
> +#define __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI 0

OK.

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/bits/long-double.h b/sysdeps/ieee754/ldbl-128ibm-compat/bits/long-double.h
> index 91dddbdc8b..ef834c7748 100644
> --- a/sysdeps/ieee754/ldbl-128ibm-compat/bits/long-double.h
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/bits/long-double.h
> @@ -22,8 +22,5 @@
>  #  define __NO_LONG_DOUBLE_MATH		1
>  # endif
>  #endif
> -/* On platforms that reuse the _Float128 implementation for IEEE long
> -   double, access to the correct long double functions is selected based
> -   on the long double mode being used during the compilation.  On
> -   powerpc64le, this is true when -mabi=ieeelongdouble is in use.  */
> -#define __LONG_DOUBLE_USES_FLOAT128 (__LDBL_MANT_DIG__ == 113)
> +
> +#define __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI (__LDBL_MANT_DIG__ == 113)

OK.

LGTM with a fixed subject

Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

-- 
Tulio Magno