From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>,
libc-alpha@sourceware.org
Cc: pc@us.ibm.com
Subject: Re: [PATCH] Make tst-strftime2 depend on locale generation
Date: Tue, 08 Oct 2019 18:48:00 -0000 [thread overview]
Message-ID: <87d0f7xeda.fsf@linux.ibm.com> (raw)
In-Reply-To: <20191008174509.22788-1-gabriel@inconstante.net.br>
"Gabriel F. T. Gomes" <gabriel@inconstante.net.br> writes:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> Building the test cases in parallel might make tst-strftime2 fail.
> Simply re-running the test case (or building with -j1) makes the problem
> go away. This patch adds the necessary dependency to allow parallel
> builds in the time subdirectory.
>
> Tested for powerpc64le.
LGTM as-is. I confirmed it solves the issue.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> diff --git a/time/Makefile b/time/Makefile
> index b9217992a6..cface6f68a 100644
> --- a/time/Makefile
> +++ b/time/Makefile
> @@ -61,6 +61,7 @@ include ../gen-locales.mk
>
> $(objpfx)tst-ftime_l.out: $(gen-locales)
> $(objpfx)tst-strptime.out: $(gen-locales)
> +$(objpfx)tst-strftime2.out: $(gen-locales)
Likewise for tst-strftime3.out ?
I've never seen an error there, but the test does depend on locales too.
--
Tulio Magno
prev parent reply other threads:[~2019-10-08 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 17:45 Gabriel F. T. Gomes
2019-10-08 18:23 ` Florian Weimer
2019-10-08 20:43 ` [PATCH v2] " Gabriel F. T. Gomes
2019-10-08 20:44 ` Florian Weimer
2019-10-08 18:48 ` Tulio Magno Quites Machado Filho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0f7xeda.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=gabriel@inconstante.net.br \
--cc=libc-alpha@sourceware.org \
--cc=pc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).