From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-81930-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 28541 invoked by alias); 10 Jul 2017 10:50:12 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 28185 invoked by uid 89); 10 Jul 2017 10:50:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=pulling
X-HELO: aserp1040.oracle.com
From: Nick Alcock <nick.alcock@oracle.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Remove debug/stack_chk_fail_local.c [BZ #21740]
References: <20170709154233.GA10935@gmail.com>
Date: Mon, 10 Jul 2017 10:50:00 -0000
In-Reply-To: <20170709154233.GA10935@gmail.com> (H. J. Lu's message of "Sun, 9
	Jul 2017 08:42:33 -0700")
Message-ID: <87d198lg6d.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2017-07/txt/msg00374.txt.bz2

On 9 Jul 2017, H. J. Lu verbalised:

> Since
>
> commit 524a8ef2ad76af8ac049293d993a1856b0d888fb
> Author: Nick Alcock <nick.alcock@oracle.com>
> Date:   Mon Dec 26 10:08:57 2016 +0100
>
>     PLT avoidance for __stack_chk_fail [BZ #7065]
>
>     Add a hidden __stack_chk_fail_local alias to libc.so,
>     and make sure that on targets which use __stack_chk_fail,
>     this does not introduce a local PLT reference into libc.so.
>
> added
>
> strong_alias (__stack_chk_fail, __stack_chk_fail_local)
>
> to debug/stack_chk_fail.c, debug/stack_chk_fail_local.c should be
> removed.
>
> OK for master?

If it passes a test build with --enable-stack-protector=all without
pulling junk into ld.so and exploding at ld.so link time, sure. (That's
what happened every time I tried to remove this stuff before, but I may
have failed to notice that this may not be necessary any more.)

> -/* On some architectures, this helps needless PIC pointer setup
> -   that would be needed just for the __stack_chk_fail call.  */

Does anyone know what architectures these might be? Presumably x86-32...

-- 
NULL && (void)