From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: Alan Modra <amodra@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 6/6] PowerPC64 ELFv2 PPC64_OPT_LOCALENTRY
Date: Tue, 13 Jun 2017 18:21:00 -0000 [thread overview]
Message-ID: <87d1a7d9zb.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170603044324.GR8842@bubble.grove.modra.org>
Alan Modra <amodra@gmail.com> writes:
> On Thu, Jun 01, 2017 at 10:41:45PM +0930, Alan Modra wrote:
>> diff --git a/sysdeps/powerpc/powerpc64/dl-machine.h b/sysdeps/powerpc/powerpc64/dl-machine.h
> [snip]
>> + && (STO_PPC64_LOCAL_MASK & refsym->st_other) == 0
>> + && (STO_PPC64_LOCAL_MASK & sym->st_other) != 0)
>> + _dl_error_localentry (map, refsym);
> [snip]
>> +extern void attribute_hidden _dl_error_localentry (struct link_map *map,
>> + const Elf64_Sym *refsym);
>
> The above of course is stupid and results in warnings "implicit
> declaration of function" and "conflicting types". I was accidentally
> building with --disable-werror, a thing I don't normally do, so missed
> seeing the error. The following revised patch fixes this and puts
> _dl_error_localentry definition inside #if _CALL_ELF == 2.
Looks good to me.
Do you plan to recover the commit message from the previous version of the
patch?
--
Tulio Magno
next prev parent reply other threads:[~2017-06-13 18:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 13:04 [PATCH 0/6] " Alan Modra
2017-06-01 13:08 ` [PATCH 1/6] PowerPC64, fix calls to _mcount Alan Modra
2017-06-12 18:07 ` Tulio Magno Quites Machado Filho
2017-06-01 13:09 ` [PATCH 2/6] PowerPC64 FRAME_PARM_SAVE Alan Modra
2017-06-12 18:07 ` Tulio Magno Quites Machado Filho
2017-06-01 13:09 ` [PATCH 3/6] PowerPC64 sysdep.h tidy Alan Modra
2017-06-12 18:12 ` Tulio Magno Quites Machado Filho
2017-06-13 1:27 ` Alan Modra
2017-06-13 17:05 ` Tulio Magno Quites Machado Filho
2017-06-01 13:10 ` [PATCH 4/6] strncpy, stpncpy and strstr fixes Alan Modra
2017-06-12 19:55 ` Tulio Magno Quites Machado Filho
2017-06-01 13:11 ` [PATCH 6/6] PowerPC64 ELFv2 PPC64_OPT_LOCALENTRY Alan Modra
2017-06-03 4:46 ` Alan Modra
2017-06-13 18:21 ` Tulio Magno Quites Machado Filho [this message]
2017-06-14 8:53 ` Alan Modra
2017-06-01 13:11 ` [PATCH 5/6] PowerPC64 ENTRY_TOCLESS Alan Modra
2017-06-13 12:23 ` Tulio Magno Quites Machado Filho
2017-06-13 14:46 ` Alan Modra
2017-06-13 17:07 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1a7d9zb.fsf@linux.vnet.ibm.com \
--to=tuliom@linux.vnet.ibm.com \
--cc=amodra@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).