public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org,  Fangrui Song <maskray@google.com>,
	 "Carlos O'Donell" <carlos@redhat.com>
Subject: Re: [PATCH v4 2/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers
Date: Fri, 16 Feb 2024 14:06:37 +0100	[thread overview]
Message-ID: <87eddc5zj6.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOpOwLeodh7M9NoTLxs585E7OzxtURMPWM6QXEh5YpRmaQ@mail.gmail.com> (H. J. Lu's message of "Fri, 16 Feb 2024 04:37:49 -0800")

* H. J. Lu:

>> > I thought that unversioned symbols interpose all versioned symbols.  Has
>> > this changed in the dynamic linker?
>>
>> Only for this case.
>>
>
> I was wrong.  Version isn't needed.  Will fix it.

Ahh.  You don't need malloc-for-test.so, either.  I think you could use
-Wl,-E (--export-dynamic) to trigger interposition from the main
program.

It would make sense to check using a counter that the interposed malloc
is in fact called.

Thanks,
Florian


  parent reply	other threads:[~2024-02-16 13:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13  4:14 [PATCH v4 0/2] " H.J. Lu
2024-02-13  4:15 ` [PATCH v4 1/2] x86-64: Save APX registers in ld.so trampoline H.J. Lu
2024-02-13  4:15 ` [PATCH v4 2/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers H.J. Lu
2024-02-14 22:44   ` Noah Goldstein
2024-02-14 23:21     ` H.J. Lu
2024-02-14 23:57       ` Noah Goldstein
2024-02-15  0:23         ` H.J. Lu
2024-02-15 23:05   ` Adhemerval Zanella Netto
2024-02-15 23:15     ` H.J. Lu
2024-02-16  6:23     ` Florian Weimer
2024-02-16 11:59       ` H.J. Lu
2024-02-16 12:18         ` Florian Weimer
2024-02-16 12:20           ` H.J. Lu
2024-02-16 12:37             ` H.J. Lu
2024-02-16 12:47               ` Adhemerval Zanella Netto
2024-02-16 12:58                 ` H.J. Lu
2024-02-16 13:24                   ` Adhemerval Zanella Netto
2024-02-16 14:25                     ` H.J. Lu
2024-02-16 13:06               ` Florian Weimer [this message]
2024-02-16 13:24                 ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eddc5zj6.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).