From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8B55D385829E for ; Fri, 16 Feb 2024 13:06:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B55D385829E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B55D385829E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708088807; cv=none; b=OYivqluSpYzM9c/MGiBNQ9hGaO4EYejuvjhuUmJY2Y8AqnPYMDk9rKNlHZbk/vLc8nboESM5/ov7kBRFqSxE0xjZ69fMGiB6wpULDkm2HRZLiQ/6w8gx/KGC7RWhDZG0w4odles04zXStbZhSk/KPS8A6YRGaUagFR4fSqVPNFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708088807; c=relaxed/simple; bh=GzM1DcWm+sIFfYY1LCMmH67Wjc6EUBZXT4EQgRdXe8M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AWmhiUvFn7zYK4+FrMnQUrt+0+JfVljsXuSD+YPYxwzey1lCX43XjbzF6BRyvVsFDRmwqk3Irv1Ysn7JMZTvIKEKbcbNcLiET3JNzvH0wjz9kz4Ohyps6ktJxnhJAHKrPK6BFeOSIzsnReJJKvqPKLrRwZU1FEGzVH6fsjBJgAk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708088804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bKfVToy+anTJLNu8gZ13l45ChIyilu9NwkNDEASVItk=; b=jU1xbvkC1aLQdXQmgzCld+4YTuj6Vn33caRh8uIiZGtl+DygECwJwe9ZDoOJMTNcCnKavp /t+TkdshUOFGDZmGPMlzI5YGNRP1DU2rtYEgWHqY1wREFNUA17+RdStBGLbUiPjj3WpeoM DBPkK88O94qDGLNsD0qSqrGIBHU3sVw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-8m0nvZOlNwy5HwGUoRKKMg-1; Fri, 16 Feb 2024 08:06:41 -0500 X-MC-Unique: 8m0nvZOlNwy5HwGUoRKKMg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5D641C05AFA; Fri, 16 Feb 2024 13:06:40 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 808242166B4F; Fri, 16 Feb 2024 13:06:39 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: Adhemerval Zanella Netto , libc-alpha@sourceware.org, Fangrui Song , "Carlos O'Donell" Subject: Re: [PATCH v4 2/2] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers References: <20240213041501.2494232-1-hjl.tools@gmail.com> <20240213041501.2494232-3-hjl.tools@gmail.com> <871q9d7wra.fsf@oldenburg.str.redhat.com> <87mss061s0.fsf@oldenburg.str.redhat.com> Date: Fri, 16 Feb 2024 14:06:37 +0100 In-Reply-To: (H. J. Lu's message of "Fri, 16 Feb 2024 04:37:49 -0800") Message-ID: <87eddc5zj6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: >> > I thought that unversioned symbols interpose all versioned symbols. Has >> > this changed in the dynamic linker? >> >> Only for this case. >> > > I was wrong. Version isn't needed. Will fix it. Ahh. You don't need malloc-for-test.so, either. I think you could use -Wl,-E (--export-dynamic) to trigger interposition from the main program. It would make sense to check using a counter that the interposed malloc is in fact called. Thanks, Florian