From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cygnus.enyo.de (cygnus.enyo.de [79.140.189.114]) by sourceware.org (Postfix) with ESMTPS id 00EE93858D20 for ; Sat, 12 Aug 2023 13:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00EE93858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de Received: from [172.17.203.2] (port=50505 helo=deneb.enyo.de) by albireo.enyo.de ([172.17.140.2]) with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1qUojw-001xE9-OA; Sat, 12 Aug 2023 13:33:12 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.96) (envelope-from ) id 1qUojw-000cvY-20; Sat, 12 Aug 2023 15:33:12 +0200 From: Florian Weimer To: Andreas Schwab Cc: Subject: Re: [PATCH] malloc: Remove bin scanning from memalign (bug 30723) References: <87pm3uajev.fsf@oldenburg.str.redhat.com> <87bkfc92hf.fsf@linux-m68k.org> <87jzu0wg0v.fsf@mid.deneb.enyo.de> Date: Sat, 12 Aug 2023 15:33:12 +0200 In-Reply-To: <87jzu0wg0v.fsf@mid.deneb.enyo.de> (Florian Weimer's message of "Sat, 12 Aug 2023 15:23:44 +0200") Message-ID: <87edk8wfl3.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Florian Weimer: > * Andreas Schwab: > >> malloc.c: In function '_int_free': >> malloc.c:4496:13: error: unused variable 'fwd' [-Werror=unused-variable] >> 4496 | mchunkptr fwd; /* misc temp for linking */ >> | ^~~ >> malloc.c:4495:13: error: unused variable 'bck' [-Werror=unused-variable] >> 4495 | mchunkptr bck; /* misc temp for linking */ >> | ^~~ >> malloc.c:4494:19: error: unused variable 'prevsize' [-Werror=unused-variable] >> 4494 | INTERNAL_SIZE_T prevsize; /* size of previous contiguous chunk */ >> | ^~~~~~~~ >> malloc.c:4493:7: error: unused variable 'nextinuse' [-Werror=unused-variable] >> 4493 | int nextinuse; /* true if nextchunk is used */ >> | ^~~~~~~~~ >> malloc.c:4492:19: error: unused variable 'nextsize' [-Werror=unused-variable] >> 4492 | INTERNAL_SIZE_T nextsize; /* its size */ >> | ^~~~~~~~ >> malloc.c:4491:13: error: unused variable 'nextchunk' [-Werror=unused-variable] >> 4491 | mchunkptr nextchunk; /* next contiguous chunk */ >> | ^~~~~~~~~ >> cc1: all warnings being treated as errors >> make[2]: *** [../o-iterator.mk:9: /home/abuild/rpmbuild/BUILD/glibc-2.38.9000.31.g084fb31bc2/cc-base/malloc/malloc.o] Error 1 > > This is a disable-tcache configuration, right? Will fix. No, the variables are always unused. This looks like a GCC bug on my side. It's strange that it appears with GCC 12 and GCC 13. Which version do you use?