public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
Cc: Libc-alpha <libc-alpha@sourceware.org>,
	 DJ Delorie <dj@redhat.com>,
	Christophe Lyon <christophe.lyon@linaro.org>
Subject: Re: [PATCH] malloc: Remove bin scanning from memalign (bug 30723)
Date: Fri, 11 Aug 2023 16:52:26 +0200	[thread overview]
Message-ID: <87edk9tyvp.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87v8dmvt2t.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Fri, 11 Aug 2023 11:14:50 +0200")

* Florian Weimer:

> * Maxim Kuvyrkov:
>
>> Hi Florian,
>>
>> This fails testing on aarch64-linux-gnu:
>>
>> FAIL: malloc/tst-memalign-2-malloc-hugetlb1
>> original exit status 1
>> error: tst-memalign-2.c:155: not true: count > LN / 2
>> error: 1 test failures
>>
>> FAIL: malloc/tst-memalign-2-malloc-hugetlb2
>> original exit status 1
>> error: tst-memalign-2.c:155: not true: count > LN / 2
>> error: 1 test failures
>>
>> FAIL: malloc/tst-memalign-2
>> original exit status 1
>> error: tst-memalign-2.c:155: not true: count > LN / 2
>> error: 1 test failures
>>
>> Let me know if you need any assistance in reproducing this.
>
> I can't reproduce this on x86-64, but looking at this particular
> subtest, I agree that it should fail after the removal of the bin
> scanning code. 8-/
>
> I'll send a v2.

And I'll need a v3.  The test is still valid with the
return-to-lowest-allocator patches in memalign, and passes.  But this
commit here applies separately without the conflict, and then the test
fails (as expected).

Thanks,
Florian


  reply	other threads:[~2023-08-11 14:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 17:36 Florian Weimer
2023-08-10 18:04 ` DJ Delorie
2023-08-11  7:20   ` Florian Weimer
2023-08-11 23:14     ` DJ Delorie
2023-08-21 14:01     ` Sam James
2023-08-21 14:45       ` Florian Weimer
2023-08-11  8:54 ` Maxim Kuvyrkov
2023-08-11  9:14   ` Florian Weimer
2023-08-11 14:52     ` Florian Weimer [this message]
2023-08-12  6:52 ` Andreas Schwab
2023-08-12 13:23   ` Florian Weimer
2023-08-12 13:33     ` Florian Weimer
2023-08-12 14:50       ` Andreas Schwab
2023-08-14  2:14       ` Xi Ruoyao
2023-08-14  9:16   ` Florian Weimer
2023-08-15 11:58     ` Adhemerval Zanella Netto
2023-08-14  9:42 Florian Weimer
2023-08-14 20:49 ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edk9tyvp.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=christophe.lyon@linaro.org \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=maxim.kuvyrkov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).