From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id AE7F13858D1E for ; Mon, 13 Mar 2023 17:32:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE7F13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32DGexqK009316; Mon, 13 Mar 2023 17:32:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=leIpjYkT0Z29LpVheK7qqvxbroSVC3TbOD3Pg03pWYQ=; b=ItLEPRuo48ldcWSlJFaHcycfMB/AWi4XyRVC+oKmqjh3QdhpdrHPxNbv5qdGZGzLfvCg qEKiRmBVmBv20WJnZbNhwA0TDhnfbOCPMGcHhBMDDX9HJNjZcJuaZXFDgqqtRua6lco2 YD6GywmrEzESfW+eWOO9sGr3UVy3Wfk08/f1+0mFfQHX9yL7b0b2pZ7eIb0Hzgwt9xF/ KE+ZK4DFhAPGezeEfpljjtA0+hXwzKVMutWQwtzAJeERWzgmDtIWfkEg+H6D0pzWjeE7 ke30NXId185GIjEgMJMtWhVLaLk0+z6fMTMk6S2QJWcDnNDVYi1UCI2EfTEBPa2TjMp3 Lg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p8g81cks6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Mar 2023 17:32:45 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32DG7WII033566; Mon, 13 Mar 2023 17:32:45 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2109.outbound.protection.outlook.com [104.47.70.109]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3p8g34r00r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Mar 2023 17:32:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0Misd/ocG4Lf2MXQErjmyntBmuXOqn50ty+CkUsBaOcnJLGyK/IHyKsFWwWFo9JAmQ1oS0NTY1Jrn+/wKLn56L7DLDo7Y6JhwcgbgOYDfIyjCA8oxe0/NKdCRXWkJr3oGGCGbOr21klAGFGbZbog3uRHHiVfmQPS75Sw9iL0Ir8h9U9Bs3/i0T8mCT3nqKRHQ4c4+RFVZTnAyIkDSCQkoHX9x96bDlxDqQPeVNslvsjESu22lAsejH7UY8n8m+9g0gL9LT4ufCW7IkwyfSAi4R7zPjOMmmG4jvXz0uyOngD/EfEsCbroZJEf0QOOYvAX7/SrKC2wmH2q9IXsxdg5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=leIpjYkT0Z29LpVheK7qqvxbroSVC3TbOD3Pg03pWYQ=; b=BjZVoOkHxOzurYsdMbzYMLEyxHTkr5FwXTzu9MxLFTi7zOe55c7y5q6b3MXMO576BQ6IFLrqg+rVE2r63zn/cKX/63b1wf+LoWzJpm4leyixUrNG8slLXBbYVEveCVKoI4EUcWWyBvUB9XRJkTs3jHE0nzNXlyR2AnMbem1mX4XloMVJzt076uCn+J/c5JXLvIjMOEPjr9QKOteqoIwNWcaKK8Mtm/9cToFeiVitPDrnvfFYYrmUDDaJY8KWUyj5TZXl4XFJo3//H8yYW+lTGFbK4mWK3bql0j2/nTUF/UZ1sbQWD+9jjoLKtY0hUX2zTlLHcyHqGH/5IqpN9NZhvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=leIpjYkT0Z29LpVheK7qqvxbroSVC3TbOD3Pg03pWYQ=; b=SzNA1jYJL8D3AL7/O3DXvwpbZKb0TrZYs1gItcf5fhPRJTH8Pxi8sFT50EzTbtE6KcZ7A33sRAdkG2Uyk1DXELpteahWNln+ZVDUH9ABFaF+PirqCVZD7BTx11HaUVliWW2EtbqqV4qzAXdU3dCHf1bM4UUiZwDwSZFj1Y7mugo= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 17:32:43 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6178.022; Mon, 13 Mar 2023 17:32:42 +0000 References: <20230310143558.361825-1-cupertino.miranda@oracle.com> <20230310143558.361825-2-cupertino.miranda@oracle.com> <87edptulvd.fsf@oldenburg.str.redhat.com> <87y1o10xs7.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Adhemerval Zanella Netto Cc: Florian Weimer , Cupertino Miranda via Libc-alpha , jose.marchesi@oracle.com, elena.zannoni@oracle.com Subject: Re: [PATCH] Created tunable to force small pages on stack allocation. In-reply-to: Date: Mon, 13 Mar 2023 17:32:37 +0000 Message-ID: <87edps1rre.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0140.eurprd05.prod.outlook.com (2603:10a6:207:3::18) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|MN2PR10MB4382:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e1f5571-5515-4b72-cb0a-08db23e8f373 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XW+YxG9h3rN3zd3vmqA3hmNwCgpAfzLKFCyi3qIVvoca9f8U2QXsiVw2nKjktNLA6PUQz+9CkZWJUYzgrrHfsw8r3Ig+7lAhvsIgtD5wm6Paji0m582dI8Xp8Fpw+VUCKGcnAgnHwte2iDXv44Ow4V+mdwJZ6wEgWKgEkDjc8cIXdamj4ss//Szvcx+TT3u3JyYN8KopH48dR7Dal/blln5iY3B3HqJqqQ1fF3KLVDwDQKBA2fqwOCzzypRjcrNNsSHhLXawmqf7sZ5klp7KUuNi4UMwXlvuIFwKfEBcYYxSazGRNGGhuFDOWLklOvCqFCQZz0yhM9hXj6nS1N8wS2QQlc8tg2V5e8v8TLYQylxQllKAolsbR3x9i8E+WfnpfwEfHoDcz2QnSDprf9WxDDHqGh9nL4vgW3XQm2mfkklDHtBR+i1bdnQRNgmo3vO9AHt7b3NrzdNoHE369PLTGGUepp3ufHiJz7QqW+h2LLxJuMNKwHw1V1a3v4xFaoTyrN2Gr38UyHgGeI1KgUxzO8E3u61WX3QiRtJWgHipVWlCePkWBtZGnKl5LIx8LeFPBpwMU3jYeUTWHeaIP9WqC5nR3rACyrH6nmUzMX68eLjhTpiApVPC/Qb2SB0t9BVqXLYqXxrkRJZJK9CEoWaQkA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(136003)(366004)(39860400002)(346002)(396003)(451199018)(6916009)(4326008)(5660300002)(8936002)(2616005)(186003)(41300700001)(6512007)(53546011)(6506007)(86362001)(36756003)(44832011)(2906002)(6666004)(66556008)(107886003)(66476007)(8676002)(6486002)(66946007)(54906003)(316002)(478600001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A/B+m7Y58S+2Aidoiz+QuMnwk+E2+8BdiXwoG8sFFuDgdKd6Q4EhZdSiHepp?= =?us-ascii?Q?sqewJqGY74eMHw9Kqn32F+1ziFlsdEqkF34f8Gya9JreRw+fswpXU2f/cDZY?= =?us-ascii?Q?YyfT8PT7lnn39ErGb535g4OhA1iMeM2zRq+nByBfDs9QFRHvU7HrF/ThThR3?= =?us-ascii?Q?u3M/rFATiO7aGuo4zdw4nbuiYgTIxJjRtHujDaC2d20hFq7PaMdsmzs6HRZ3?= =?us-ascii?Q?T0EwbMoLEDjDmOt0/CHRcNrMlOc9IWCDIoFKCyjVFfvuyjrGi+UPibAdn5Or?= =?us-ascii?Q?IHDqf+hrf/yhD4G2wnMnx48mmNOBiN1hWwuXAlhgXfOUZtyZ55tEdDjVaVNn?= =?us-ascii?Q?pFU5MewRiAxuZXNm0g74Auz/h8f0WqN2+VpX0tPC7hhfG3eFA+kdsR4f9ahF?= =?us-ascii?Q?a9GstQNHHTHzmEGBZBBZolp11Q5/qPoctuS67bNY85duI3XBmyflx0kCTbqJ?= =?us-ascii?Q?ep6lB+ZIUvtCTvNZCKXYeo7GMOqiG5DMNFc8i3o/1FkXqh1FKCkGiOnGKAU5?= =?us-ascii?Q?SokDWDq0n1lYw9CICu//EfH/1rNz1Yeg7R/zh1hnXRC9UCC2Bg364ET2vliB?= =?us-ascii?Q?itEi10k8vehs5UcfnuXPLBjIntHazU3CGF20rpHzgHL/Q+IbaxazbkDhVceN?= =?us-ascii?Q?ISDn8OcEEQauA8FrTLBHqr4hWo2LW2PLej+miT1AjBvjy3m+fWbNd/0r6b4l?= =?us-ascii?Q?nH22Bas2NZwiG5URArCe+kKgTMVJW7C0aM+tiSnxePnCCGEOS3mSIwkQOj8R?= =?us-ascii?Q?EfxUHChf4J69KZAO0p6iYYjiJb/WlQrr0aW7tzL5kNTFKyeQXraJF5A/fWNA?= =?us-ascii?Q?MBqev2HZP6VfXQ9gjwZ8ZckE988GFL/Qi8z8193wbljuv6J2jSBGAva3vanv?= =?us-ascii?Q?jodO0QQRXREz54QyCOd2pDCKsx1LzcL7W+/ncINB/94dPX0Gde3ite4GQiZj?= =?us-ascii?Q?pOna7y/j8hayX0T1wXP27eEpRTn203xqKEz9wFrGOFkftUC9rqeA/fznQt41?= =?us-ascii?Q?Ere7q+wYpux9MqVkf6vgrFPptZfhI2oNJGjGJ9TaZyao3Xh6CSIGcfkbZaBU?= =?us-ascii?Q?rcA9H+tQVCFJ7turlVozcHP0gsKasQg/EIv8+NKpywocYX73nyWLgVKfz7ly?= =?us-ascii?Q?y2g5NSGWEKIWoykt2MHjTK6uCp6JajZKag+D/w4lqU6Rq5h2fNAJEewmOaYI?= =?us-ascii?Q?ou7VgZS94m+F5Od1sEx71Nl2Y8hJUDgYVwkoQuI7S2LDlC2ESqYNI7AxRy+X?= =?us-ascii?Q?xvpOOEW3x8Z7siW5g86RH+RxCfKlwo+e5tyb8lAm8o141PFUtbFsSwviTgrX?= =?us-ascii?Q?BTTlorP/Wz2Y23974Qudr+hj5EkYG9BDYgzETr/o1zWIdWwWTTOAdK+jrjai?= =?us-ascii?Q?lVTg5zZ/pLua7iBgMrJf0Ie4hZ1bdmsw0iLDhELmCyGuOSUjI0vDI0Cmoxbn?= =?us-ascii?Q?ONihEZFhqBvLa+9W7fPVtuvvTlx8CDVBJwo4NkK3Al6FC0psAuZfFi+ZMOoL?= =?us-ascii?Q?Q1tazP4Y0B0VFOzownYSrBOYSyoXxvmVL4wpFZYQLsJUdXpcQm89zpg8T5R9?= =?us-ascii?Q?cc9AmKWpqzxJiE5q0l+towNpLojSPc55oqbPUKWah611SMww2xMOw+Zkr8D9?= =?us-ascii?Q?6JRZ0wUk7ftTa74dChJoOdQQG+t/i94/o8WOMAcWhq4X?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: O9k12iH5CGuzq/xi5mMUqJ55SoPRAwNn9PPTTVv0LzCraGYWQnkERJZCZ7q+9ZWSDxaTrWuRqRui4tJRjcKaqJPPRV2bb76ALh8iS8I1wAZIyifeIHR/9jEbvNY2gvZTsGvQObhaTe8CUTDXxIfbWR4HD2NatSVE9+2aEO1yDj4yBCPghCOn6YAr6opAM9XmTcuXfv8WGyIk5esNk975Ak921Cxbm3lvSBjlChczmGETJvJ4sfQBjLdMGbWioVAKuvGOHFK4krwz66FLq2nJbq/x4EPO2rmMsswQIUA6WL5FHF956dKOZCs2aSUpDIemzM5dJ0Go3F/ZMxQQkTuUFP8JHLyHeX+cjGyCUhTz6B+a6hkG0u8JzMJObxBIMuGgaL0hX9Jt+PBa6A56vPtBVPyUmYRGDzd74VpPhCandjQR4fit4yb6R31gcJWUQiqXAzqFiXkGFDXd8Vp3cYFNcRxNW7jYlHn485sdhLj636DEsGRZhtaX/CpD0Bgl//NEzOPL3QmAYyAbztp/b37UCAhc8g53FGCDxLxWIJ0WcR7o6pGFQ0VYJ94esRGByiRCH39cfQnXRG+iyszGNSeOUVb+6f1OSPNDJXVFMJG7tc99a7j9cSq0dP+4c13WLqm60Qgrya77h4nWJqbHArlxzrPYJOSsDEF8GuY3Exuq/1cnn6t6ZUYPYSJ7cuf5RhJIcQdamjNq2OmLgEU35AAKK34zGEDGxK6fo62oOSistpdZt3SRSlLHGx7n6MpClETmbquNOsT6foeQwT7ApbvGqQswYkEg3o/lzaKgQMBpO4Bk6+xRP2DX96hNuCMDEo4M X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1f5571-5515-4b72-cb0a-08db23e8f373 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 17:32:42.9081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AixShsiVHM3N1IfnaoxuXnP8cvZKoVD69P6erDs/tJ6BAg2lAoaz9LlCoKkT7rqh6fdgE4A7Ut5B99ZkXK3XoNf0i7Iy4UQu5/ruh3x7HGw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4382 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-13_09,2023-03-13_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303130136 X-Proofpoint-ORIG-GUID: xzP8SwRXG0sqGOyp0HdmFIiMSsKKFLOg X-Proofpoint-GUID: xzP8SwRXG0sqGOyp0HdmFIiMSsKKFLOg X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Adhemerval Zanella Netto writes: > On 13/03/23 07:07, Cupertino Miranda wrote: >> >> Hi Florian >> >>> * Cupertino Miranda via Libc-alpha: >>> >>>> +static void >>>> +TUNABLE_CALLBACK (set_stack_hugetlb) (tunable_val_t *valp) >>>> +{ >>>> + enum malloc_thp_mode_t thp_mode = __malloc_thp_mode (); >>>> + /* >>>> + Only allow to change the default of this tunable if the system >>>> + does support and has either 'madvise' or 'always' mode. Otherwise >>>> + the madvise() call is wasteful. >>>> + */ >>>> + switch(thp_mode) >>>> + { >>>> + case malloc_thp_mode_always: >>>> + case malloc_thp_mode_madvise: >>>> + __nptl_stack_hugetlb = (int32_t) valp->numval; >>>> + break; >>>> + default: >>>> + break; >>>> + } >>>> +} >>> >>> I suspect that quite a few failing madvise calls are cheaper than the >>> those three system calls in __malloc_thp_mode. In addition, >>> __malloc_thp_mode may fail due to future kernel changes, disabling the >>> tunable by accident. >> Thanks for your review. Ok, I did not check the inner workings of >> malloc_thp_mode. I used it by suggestion from the RFC thread. >> I will prepare a version removing it. > > It only make sense to madvise iff __malloc_thp_mode is set as 'always', > and tunable is a opt-in feature. So I think it would make sense to > check the sysfs is tunable is used; the startup code will be amortized > on high threads workloads. >From my side either solution is Ok. Using the __malloc_thp_mode would protect the code from calls to madvise in systems that do not have hugetlb support. This would avoid returning an error on madvise if the advice argument is not identified as valid.