From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=T/K7=5G=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by sourceware.org (Postfix) with ESMTPS id 665AC3858D3C
	for <libc-alpha@sourceware.org>; Mon,  9 Jan 2023 15:32:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 665AC3858D3C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1673278352;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=eApTU7LiYTmn/JJs08z8X8hyVAlAw90svc6RHw/Ogzk=;
	b=LYeDV7v2Ail1pPjrs7A9nRg1zwIDaxWUwf9oRsWSuTWDbjOVNtXkP+05ZcyM8j9gPhiAc3
	/SmiTq3nkcaUFPngGGb+eraZeDLa9Bl7mZ0QHOdQmzVkGyQRNWcnKUKz0fhQ5YqjNIJNo3
	OuaU6oVPr4DWjv/3HSSpClW42UNC0pA=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-474-HkSmuibaNIqHEvbze3NvnQ-1; Mon, 09 Jan 2023 10:32:30 -0500
X-MC-Unique: HkSmuibaNIqHEvbze3NvnQ-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B60B1C06EEA;
	Mon,  9 Jan 2023 15:32:30 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.32])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FBF8407D47A;
	Mon,  9 Jan 2023 15:32:29 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] Add _FORTIFY_SOURCE implementation documentation [BZ
 #28998]
References: <20221215162506.1802077-1-siddhesh@sourceware.org>
	<20221222160403.4151387-1-siddhesh@sourceware.org>
Date: Mon, 09 Jan 2023 16:32:27 +0100
In-Reply-To: <20221222160403.4151387-1-siddhesh@sourceware.org> (Siddhesh
	Poyarekar's message of "Thu, 22 Dec 2022 11:04:03 -0500")
Message-ID: <87eds3k9kk.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Siddhesh Poyarekar:

> +The following functions are fortified in @theglibc{}:
> +
> +@itemize @bullet
> +@item @code{asprintf}: Replaced with @code{__asprintf_chk}.
> +
> +@item @code{confstr}: Replaced with @code{__confstr_chk}.
> +
> +@item @code{dprintf}: Replaced with @code{__dprintf_chk}.

For the *printf* functions, the replacement depends on the architecture
and compilation mode (the concrete type of long double).

> +@item @code{explicit_bzero}: Replaced with @code{__explicit_bzero_chk}.
> +
> +@item @code{FD_SET}: Replaced with @code{__fdelt_chk}.
> +
> +@item @code{FD_CLR}: Replaced with @code{__fdelt_chk}.
> +
> +@item @code{FD_ISSET}: Replaced with @code{__fdelt_chk}.

These three macros (not functions) aren't replaced, but enhanced.

Maybe just mentioned the list of functions/macros, and point towards the
general pattern, but also note the presence of exceptions?

Rest looks okay to me.

Thanks,
Florian