From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id 09A7D3857372
	for <libc-alpha@sourceware.org>; Fri, 28 Oct 2022 11:30:48 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09A7D3857372
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666956647;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tmZIjEjt61h+PBc9XmNn9PUIDuO2n76xwQT4qAM4xxk=;
	b=fzvgSjWkhpw1nHQpgAUwVCv6zzamhyfUMYwglP4aL78B3s69mdmhRtCyEVH2bYZyU1Fcin
	5umQpFpQB/oocxfjeWKa1vPcj/jpnUgHIVZQuzERKOR9K0b5xJidDumEVbXDc4Qw5bGcxH
	a0WhFE2lk5RQfded+7AxHqV2dzgfY1o=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-413-czA-oDorNIynw_8xnHaWQw-1; Fri, 28 Oct 2022 07:30:46 -0400
X-MC-Unique: czA-oDorNIynw_8xnHaWQw-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C199B29A9D28;
	Fri, 28 Oct 2022 11:30:45 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.74])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id EC8292166B2C;
	Fri, 28 Oct 2022 11:30:44 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 16/20] Fix malloc/tst-scratch_buffer OOB access
References: <cover.1666877952.git.szabolcs.nagy@arm.com>
	<b4ecb76a1c47dfac8344706e365686bd2620affe.1666877952.git.szabolcs.nagy@arm.com>
	<87zgdgh5du.fsf@oldenburg.str.redhat.com> <Y1u70FoFT0KeMVEw@arm.com>
Date: Fri, 28 Oct 2022 13:30:43 +0200
In-Reply-To: <Y1u70FoFT0KeMVEw@arm.com> (Szabolcs Nagy's message of "Fri, 28
	Oct 2022 12:24:00 +0100")
Message-ID: <87edusfan0.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Szabolcs Nagy:

>> I think we should keep the test loop, but create a new scratch buffer on
>> each iteration.
>
> given the documentation of scratch_buffer_dupfree
> i don't see how the test supposed to work with
> sizes > buf.length or what's the point of this loop.

Hmph.  Let's just remove it.  It's unused anyway.  Should I send a
patch, or do you want to do it?

Thanks,
Florian