From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by sourceware.org (Postfix) with ESMTPS id 279D43856DCC for ; Thu, 5 May 2022 11:39:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 279D43856DCC Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-164-pfNzLecuOS2CK7Gtsb5EMg-1; Thu, 05 May 2022 07:39:19 -0400 X-MC-Unique: pfNzLecuOS2CK7Gtsb5EMg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6AA9F3C92FC9; Thu, 5 May 2022 11:39:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6288F2166B17; Thu, 5 May 2022 11:39:18 +0000 (UTC) From: Florian Weimer To: Alejandro Colomar Cc: GNU C Library , "H.J. Lu" Subject: Re: [PATCH v2 2/3] Linux: Implement a useful version of _startup_fatal References: <63235b8cfce808ff0c6fd07d5710faaf2e692f88.1651682800.git.fweimer@redhat.com> <4681247d-2316-6b11-ef43-52b68050c31b@gmail.com> Date: Thu, 05 May 2022 13:39:16 +0200 In-Reply-To: <4681247d-2316-6b11-ef43-52b68050c31b@gmail.com> (Alejandro Colomar's message of "Wed, 4 May 2022 22:59:57 +0200") Message-ID: <87ee18nr8b.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 11:39:24 -0000 * Alejandro Colomar: > Hi Florian, > > On 5/4/22 20:34, H.J. Lu via Libc-alpha wrote: >> On Wed, May 4, 2022 at 9:48 AM Florian Weimer wrote: >>> >>> On i386 and ia64, the TCB is not available at this point. >>> --- >>> v2: Add ia64 override. On i386, use non-TCB version for non-PIE static, too. >>> sysdeps/unix/sysv/linux/i386/startup.h | 21 ++------------ >>> sysdeps/unix/sysv/linux/ia64/startup.h | 22 +++++++++++++++ >>> sysdeps/unix/sysv/linux/startup.h | 38 ++++++++++++++++++++++++++ >>> 3 files changed, 63 insertions(+), 18 deletions(-) >>> create mode 100644 sysdeps/unix/sysv/linux/ia64/startup.h >>> create mode 100644 sysdeps/unix/sysv/linux/startup.h >>> >>> diff --git a/sysdeps/unix/sysv/linux/i386/startup.h b/sysdeps/unix/sysv/linux/i386/startup.h >>> index 67c9310f3a..85534d09f1 100644 >>> --- a/sysdeps/unix/sysv/linux/i386/startup.h >>> +++ b/sysdeps/unix/sysv/linux/i386/startup.h >>> @@ -16,22 +16,7 @@ >>> License along with the GNU C Library; if not, see >>> . */ >>> >>> -#if BUILD_PIE_DEFAULT >>> -/* Can't use "call *%gs:SYSINFO_OFFSET" during statup in static PIE. */ >>> -# define I386_USE_SYSENTER 0 >>> +/* Can't use "call *%gs:SYSINFO_OFFSET" during statup. */ > > Typo? > > s/statup/startup/ I've fixed this in the two files I changed. Thanks, Florian