From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 370EC3858D28
 for <libc-alpha@sourceware.org>; Mon, 25 Apr 2022 15:38:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 370EC3858D28
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-16-IQwicJ-FMNG_cij_A3GAWw-1; Mon, 25 Apr 2022 11:38:47 -0400
X-MC-Unique: IQwicJ-FMNG_cij_A3GAWw-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
 [10.11.54.7])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E4DD618E5340;
 Mon, 25 Apr 2022 15:38:46 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.193.187])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 6906E1468942;
 Mon, 25 Apr 2022 15:38:46 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 3/6] nss: Add tests for the nss_hash in nss_hash.h
References: <20220414041231.926415-1-goldstein.w.n@gmail.com>
 <20220414145540.194794-1-goldstein.w.n@gmail.com>
 <20220414145540.194794-3-goldstein.w.n@gmail.com>
Date: Mon, 25 Apr 2022 17:38:45 +0200
In-Reply-To: <20220414145540.194794-3-goldstein.w.n@gmail.com> (Noah Goldstein
 via Libc-alpha's message of "Thu, 14 Apr 2022 09:55:37 -0500")
Message-ID: <87ee1lnpfe.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Apr 2022 15:38:52 -0000

* Noah Goldstein via Libc-alpha:

> +static int
> +do_fill_tests (size_t len, int fill)
> +{
> +  uint32_t expec, res;
> +  char buf[len];
> +  memset (buf, fill, len);
> +
> +  expec = simple_nss_hash (buf, len);
> +  res = __nss_hash (buf, len);
> +  if (expec != res)
> +    {
> +      printf ("FAIL: fill(%d) (%lu), %x != %x\n", fill, len, expec, res);
> +      return 1;
> +    }
> +
> +  return 0;
> +}

%lu needs to be %zu, otherwise this fails to build on various
architectures.

Thanks,
Florian