From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id 3105C3888C70
 for <libc-alpha@sourceware.org>; Wed, 30 Mar 2022 20:14:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3105C3888C70
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de
Received: from [172.17.203.2] (port=48231 helo=deneb.enyo.de)
 by albireo.enyo.de ([172.17.140.2]) with esmtps
 (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
 id 1nZehy-008Qk0-Dm; Wed, 30 Mar 2022 20:14:22 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.94.2)
 (envelope-from <fw@deneb.enyo.de>)
 id 1nZehy-0006Xi-3V; Wed, 30 Mar 2022 22:14:22 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] Add .clang-format style file
References: <20220328191254.913833-1-goldstein.w.n@gmail.com>
 <20220330192714.3177346-1-goldstein.w.n@gmail.com>
 <87k0cbgqgk.fsf@mid.deneb.enyo.de>
 <CAFUsyf+=aM=c3nK4AC1NrF0oYz+ns9h+YX7iUHv1+8rhCexP2w@mail.gmail.com>
Date: Wed, 30 Mar 2022 22:14:22 +0200
In-Reply-To: <CAFUsyf+=aM=c3nK4AC1NrF0oYz+ns9h+YX7iUHv1+8rhCexP2w@mail.gmail.com>
 (Noah Goldstein's message of "Wed, 30 Mar 2022 15:09:07 -0500")
Message-ID: <87ee2jgpup.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2022 20:14:30 -0000

* Noah Goldstein:

>> > +UseTab:          Never
>>
>> I prefer not using tabs, but others disagree, and most of the source
>> files use tabs instead of 8 spaces (and not just for indentation).
>
> +1 but yeah the consistent style seems to be tabs so will update in v4.

Is there an option to use tabs only if the file contains tab?

>> > +ForEachMacros:
>> > +  - 'FOR_EACH_IMPL'
>> > +  - 'list_for_each'
>> > +  - 'list_for_each_prev'
>> > +  - 'list_for_each_prev_safe'
>>
>> If this is a YAML file, do these duplicate FoEachMacros keys have any
>> effect?  Only the second one is relevant to glibc.
>
> They all seem to have an effect.

<https://yaml.org/spec/1.2.2/#mapping> says that keys have to be
unique, so I don't think to ForEachMacros is valid YAML syntax.

> What do you mean only the second is relevant?

glibc does not use the Boost and Qt macros.