From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 773EC3858D35 for ; Fri, 10 Dec 2021 12:41:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 773EC3858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-476-yCFJvHZePEKGr4Igd0C1IQ-1; Fri, 10 Dec 2021 07:40:59 -0500 X-MC-Unique: yCFJvHZePEKGr4Igd0C1IQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2A5D81EE60; Fri, 10 Dec 2021 12:40:58 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B68D319C59; Fri, 10 Dec 2021 12:40:57 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v6 02/20] elf: Add _dl_audit_objopen References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-3-adhemerval.zanella@linaro.org> Date: Fri, 10 Dec 2021 13:40:55 +0100 In-Reply-To: <20211115183734.531155-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 15 Nov 2021 15:37:16 -0300") Message-ID: <87ee6kaazs.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 12:41:05 -0000 * Adhemerval Zanella: > diff --git a/elf/Makefile b/elf/Makefile > index 8f3e3a3602..80ed31edbe 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -36,7 +36,7 @@ dl-routines = $(addprefix dl-,load lookup object reloc deps \ > exception sort-maps lookup-direct \ > call-libc-early-init write \ > thread_gscope_wait tls_init_tp \ > - debug-symbols minimal-malloc) > + debug-symbols minimal-malloc audit) You can drop the #ifdef SHARED if you add this to rtld-routines. > +/* Call the la_objopen() from the audit modules for the link_map L on the > + namespace identification NSID. If CHECK_AUDIT is set it will also check > + if main mapping of the namespace is a audit modules. */ > +void _dl_audit_objopen (struct link_map *l, Lmid_t nsid, bool check_audit); No () after function name (not sure?) Should check_audit be named require_auditing? That would align better with the l_auditing check, I think. Rest looks okay. Thanks, Florian