From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id E29F03858412
 for <libc-alpha@sourceware.org>; Fri, 15 Oct 2021 07:18:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E29F03858412
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de
Received: from [172.17.203.2] (port=33101 helo=deneb.enyo.de)
 by albireo.enyo.de ([172.17.140.2]) with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1mbHU0-0004oT-4r; Fri, 15 Oct 2021 07:18:24 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.94.2)
 (envelope-from <fw@deneb.enyo.de>)
 id 1mbHTz-0005yS-R1; Fri, 15 Oct 2021 09:18:23 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] nss: Unnest nested function add_key
References: <20211015053246.363952-1-maskray@google.com>
Date: Fri, 15 Oct 2021 09:18:23 +0200
In-Reply-To: <20211015053246.363952-1-maskray@google.com> (Fangrui Song via
 Libc-alpha's message of "Thu, 14 Oct 2021 22:32:46 -0700")
Message-ID: <87ee8mycw0.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Oct 2021 07:18:27 -0000

* Fangrui Song via Libc-alpha:

> Add one static variable `db`, but make makedb.c compilable with Clang.

=E2=80=9Ccur_db=E2=80=9D?

Please use the twalk_r function, it was added for such situations.