From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id 1EADA3858402
 for <libc-alpha@sourceware.org>; Thu, 26 Aug 2021 14:43:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EADA3858402
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-321-vSpbd3inPaWCjssSzSUyOw-1; Thu, 26 Aug 2021 10:43:20 -0400
X-MC-Unique: vSpbd3inPaWCjssSzSUyOw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74B06802937;
 Thu, 26 Aug 2021 14:43:19 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.194.140])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F7395D9FC;
 Thu, 26 Aug 2021 14:43:18 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 17/19] nptl: Use tidlock when accessing TID on
 pthread_sigqueue
References: <20210823195047.543237-1-adhemerval.zanella@linaro.org>
 <20210823195047.543237-18-adhemerval.zanella@linaro.org>
Date: Thu, 26 Aug 2021 16:43:16 +0200
In-Reply-To: <20210823195047.543237-18-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella's message of "Mon, 23 Aug 2021 16:50:45 -0300")
Message-ID: <87eeag5ksb.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Aug 2021 14:43:23 -0000

* Adhemerval Zanella:

> +  /* Block all signal, since the lock is recursive and used on pthread_cancel
> +     (which should be async-signal-safe).  */
> +  sigset_t oldmask;
> +  __libc_signal_block_all (&oldmask);
> +  lll_lock (pd->tidlock, LLL_PRIVATE);
> +
> +  int res;
> +  if (pd->tid == 0)
> +    {
> +      pid_t pid = getpid ();

Huh, that can't be right, should be pd->tid != 0.

Don't we have test coverage for this?

> +  else
> +    res = -ESRCH;

We can return 0 in this case, I think.

It's possibly that the same issue regarding synchronous signal delivery
for pthread_jill applies here.

Thanks,
Florian