From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 1543B3857800 for ; Tue, 8 Dec 2020 15:18:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1543B3857800 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-5VOHpg6bOqWxR0TNrrmnXA-1; Tue, 08 Dec 2020 10:18:13 -0500 X-MC-Unique: 5VOHpg6bOqWxR0TNrrmnXA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BE30C85819B; Tue, 8 Dec 2020 15:18:11 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-171.ams2.redhat.com [10.36.112.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E038E5D6D5; Tue, 8 Dec 2020 15:18:10 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Alexandra =?utf-8?B?SMOhamtvdsOh?= Subject: Re: [PATCH] Linux: Add execveat system call wrapper References: <20200428122019.26826-1-ahajkova@redhat.com> <20201203142053.897832-1-ahajkova@redhat.com> <483f4dad-3b2f-0267-30f6-677580facd22@linaro.org> Date: Tue, 08 Dec 2020 16:18:09 +0100 In-Reply-To: <483f4dad-3b2f-0267-30f6-677580facd22@linaro.org> (Adhemerval Zanella's message of "Tue, 8 Dec 2020 11:44:33 -0300") Message-ID: <87eek0coni.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 15:18:16 -0000 * Adhemerval Zanella: > On 03/12/2020 11:20, Alexandra H=C3=A1jkov=C3=A1 via Libc-alpha wrote: >> From: Alexandra H=C3=A1jkov=C3=A1 >>=20 >> Also add the test for the new wrapper. >> --- >> This version: >> * extends NEWS entry >> * adds various one line comments >> * uses exit $FOO instead of exit 3 to test if FOO was set properly >> * removes the implicit check >> * improves comments >> * removes unnecessary Makefile change >> * returns INLINE_SYSCALL_CALL return value >>=20 >>=20 > > There are some formatting issues on comment the test, I think we should > nonnull for envp as well, and some changes on the Linux implementation I think envp =3D=3D NULL is a well-documented Linux extension, in wide use with execve. Thanks, Florian --=20 Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'N= eill