From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 360BC393C851 for ; Mon, 28 Sep 2020 13:35:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 360BC393C851 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-245-b42Mtx12Mxu-bgW0k_eN0w-1; Mon, 28 Sep 2020 09:35:27 -0400 X-MC-Unique: b42Mtx12Mxu-bgW0k_eN0w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F3421021202; Mon, 28 Sep 2020 13:35:26 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-84.ams2.redhat.com [10.36.114.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDA1055781; Mon, 28 Sep 2020 13:35:25 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Cc: "H.J. Lu" , Siddhesh Poyarekar Subject: Re: [PATCH 2/4] Set tunable value as well as min/max values References: <20200918160709.949608-1-hjl.tools@gmail.com> <20200918160709.949608-3-hjl.tools@gmail.com> Date: Mon, 28 Sep 2020 15:35:24 +0200 In-Reply-To: <20200918160709.949608-3-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Fri, 18 Sep 2020 09:07:07 -0700") Message-ID: <87eemm6n37.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2020 13:35:33 -0000 * H. J. Lu via Libc-alpha: > Some tunable values and their minimum/maximum values must be determinted > at run-time. Add TUNABLE_SET_ALL and TUNABLE_SET_ALL_FULL to update > tunable value together with minimum and maximum values. __tunable_set_val > is updated to set tunable value as well as min/max values. I'm not sure if this change is philosophically correct as far as the tunables framework is concerned. I had thought the limits should be something static, so that they are consistent across systems. Maybe Siddhesh can comment on that aspect? What is supposed to happen if you specify an out-of-range value? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill