From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 494C63857806 for ; Thu, 10 Sep 2020 13:41:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 494C63857806 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08ADWIMI056933; Thu, 10 Sep 2020 09:41:00 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 33fmyggngy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 09:41:00 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 08ADXAmk060667; Thu, 10 Sep 2020 09:41:00 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 33fmyggng5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 09:40:59 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 08ADVt8g006400; Thu, 10 Sep 2020 13:40:59 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma01dal.us.ibm.com with ESMTP id 33d46n4e7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 13:40:59 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 08ADewQw59507110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Sep 2020 13:40:58 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1CFDC6055; Thu, 10 Sep 2020 13:40:57 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B90DC605D; Thu, 10 Sep 2020 13:40:57 +0000 (GMT) Received: from linux.ibm.com (unknown [9.65.204.29]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 10 Sep 2020 13:40:57 +0000 (GMT) From: Tulio Magno Quites Machado Filho To: Joseph Myers , Matheus Castanho , "Carlos O'Donell" Cc: patsy@redhat.com, libc-alpha@sourceware.org Cc: Subject: Re: [PATCH v2] powerpc: Update ULPs and output for j0 with ibm128 In-Reply-To: References: <20200909165830.64343-1-msc@linux.ibm.com> User-Agent: Notmuch/0.29.1 (http://notmuchmail.org) Emacs/26.3 (x86_64-redhat-linux-gnu) Date: Thu, 10 Sep 2020 10:40:56 -0300 Message-ID: <87een93g2f.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-10_03:2020-09-10, 2020-09-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 clxscore=1011 suspectscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009100120 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2020 13:41:09 -0000 Joseph Myers writes: > On Wed, 9 Sep 2020, Matheus Castanho wrote: > >> Instead of updating the ldouble ULPs for j0 with an upstream GCC, >> constantly increasing their values, this patch regenerates them with a >> GCC compiled with the patch mentioned above. This way we have the actual >> precise ULPs listed in libm-test-ulps. Of course, when compiling with >> an upstream compiler some tests will fail as the calculated ULPs will be >> higher than the expected ones. For such tests, we mark the >> corresponding entries in math/auto-libm-test-in with >> xfail-rounding:ibm128-libgcc. > > xfail-rounding:ibm128-libgcc is intended for the sort of edge cases where > upstream GCC produces results that are wildly off. It's not intended for > these sorts of cases where it gives slightly bigger ulps that are still > within the accepted bounds. Carlos, Joseph, I'm afraid that Matheus is either in a deadlock or we need a clearer explanation of what is acceptable for ibm128. Notice that Matheus' first patch was rejected because results were greater than 9. With that said, would both of you accept the first version of this patch? https://patchwork.sourceware.org/project/glibc/patch/20200820183700.115087-1-msc@linux.ibm.com/ -- Tulio Magno