From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 03468385EC54 for ; Wed, 29 Jul 2020 16:25:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03468385EC54 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-E_lZovOxO9aDDw6iAOHnyw-1; Wed, 29 Jul 2020 12:25:48 -0400 X-MC-Unique: E_lZovOxO9aDDw6iAOHnyw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFA2F1893DC6; Wed, 29 Jul 2020 16:25:46 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-29.ams2.redhat.com [10.36.113.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC2E319D82; Wed, 29 Jul 2020 16:25:45 +0000 (UTC) From: Florian Weimer To: Alan Modra via Libc-alpha Cc: Joseph Myers , Alan Modra , binutils@sourceware.org Subject: Re: Emit a warning when -z relro is unsupported References: <20200619024818.GA21885@bubble.grove.modra.org> <20200729003850.GO9601@bubble.grove.modra.org> <20200729071002.GP9601@bubble.grove.modra.org> Date: Wed, 29 Jul 2020 18:25:44 +0200 In-Reply-To: <20200729071002.GP9601@bubble.grove.modra.org> (Alan Modra via Libc-alpha's message of "Wed, 29 Jul 2020 16:40:02 +0930") Message-ID: <87eeounv93.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2020 16:25:57 -0000 * Alan Modra via Libc-alpha: > From 3425515f19d47eb2e13180fe031d94a9c13ce39b Mon Sep 17 00:00:00 2001 > From: Alan Modra > Date: Wed, 29 Jul 2020 16:28:57 +0930 > Subject: Don't mix linker error messages into edited scripts > > * Makerules (shlib.lds): Discard linker warning output. > (format.lds): Likewise. > > diff --git a/Makerules b/Makerules > index 341db86c7e..ef0fe67d9a 100644 > --- a/Makerules > +++ b/Makerules > @@ -557,7 +557,7 @@ $(common-objpfx)shlib.lds: $(common-objpfx)config.make $(..)Makerules > $(LINK.o) -shared -Wl,-O1 \ > -nostdlib -nostartfiles \ > $(sysdep-LDFLAGS) $(rtld-LDFLAGS) $(LDFLAGS.so) \ > - -Wl,--verbose 2>&1 | \ > + -Wl,--verbose 2>/dev/null | \ > sed > $@T \ > -e '/^=========/,/^=========/!d;/^=========/d' \ > $(if $(filter yes,$(have-hash-style)), \ > @@ -1073,7 +1073,7 @@ ifneq (unknown,$(output-format)) > else > $(LINK.o) -shared $(sysdep-LDFLAGS) $(rtld-LDFLAGS) \ > $(LDFLAGS.so) $(LDFLAGS-lib.so) \ > - -x c /dev/null -o $@.so -Wl,--verbose -v 2>&1 \ > + -x c /dev/null -o $@.so -Wl,--verbose -v 2>/dev/null \ > | sed -n -f $< > $@.new > test -s $@.new > rm -f $@.so This change looks reasonable to me. Thanks for tracking this down. We are in the glibc 2.32, so Carlos as the release manager needs to approve this. Florian