From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 7C9EC383E806 for ; Mon, 25 May 2020 14:28:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7C9EC383E806 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-zki0UNuaMSydn2AairT2eA-1; Mon, 25 May 2020 10:28:54 -0400 X-MC-Unique: zki0UNuaMSydn2AairT2eA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BFC380183C; Mon, 25 May 2020 14:28:53 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99CDD53E02; Mon, 25 May 2020 14:28:51 +0000 (UTC) From: Florian Weimer To: Mathieu Desnoyers Cc: libc-alpha , Joseph Myers Subject: Re: [PATCH glibc 0/3] Restartable Sequences enablement References: <20200501021439.2456-1-mathieu.desnoyers@efficios.com> <87r1vebzl6.fsf@oldenburg2.str.redhat.com> <250952375.33263.1590414739268.JavaMail.zimbra@efficios.com> Date: Mon, 25 May 2020 16:28:49 +0200 In-Reply-To: <250952375.33263.1590414739268.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Mon, 25 May 2020 09:52:19 -0400 (EDT)") Message-ID: <87eer8w0ke.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 14:28:59 -0000 * Mathieu Desnoyers: > ----- On May 20, 2020, at 7:44 AM, Florian Weimer fweimer@redhat.com wrote: > >> * Mathieu Desnoyers via Libc-alpha: >> >>> Florian, if you find the patches OK and possibly with a bit of >>> tweaking of the commit messages, can you please commit them >>> to glibc ? >> >> I had some final review comments, and I found a real bug: the uptr >> changes in are problematic. > > Hi Florian, > > Can you share what issue you have found with the uptr changes ? I thought I had written about something here: But it's not very explicit. I must have deleted it before sending it. The problem is that you made substantial changes to the fallback definitions compared to the kernel version. But those will never be used if the user has the appropriate kernel headers installed. The fallback part really has to be an almost-verbatim copy of the kernel definitions. Thanks, Florian