Re: V2 [PATCH 2/2] Add C wrappers for prctl/process_vm_readv/process_vm_writev [BZ #25810]

[Florian Weimer <fweimer@redhat.com>]

* H. J. Lu:

> With
>
> extern int __prctl (int __option, ...);
> libc_hidden_proto (__prctl)
> libc_hidden_proto (prctl)
>
> and
>
> #include <unistd.h>
> #include <sysdep.h>
> #include <errno.h>
> #include <sys/prctl.h>
>
> int
> __prctl (int option, unsigned long int arg2, unsigned long int arg3,
> unsigned long int arg4, unsigned long int arg5)
> {
>   return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5);
> }
>
> libc_hidden_def (__prctl)
> weak_alias (__prctl, prctl)
> hidden_weak (prctl)

Please try:

extern int __prctl (int __option, ...);
libc_hidden_proto (__prctl)

And:

int
__prctl (int option, unsigned long int arg2, unsigned long int arg3,
unsigned long int arg4, unsigned long int arg5)
{
  return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5);
}
libc_hidden_def (__prctl)
strong_alias (__prctl, prctl)

Internal users should always use __prctl to avoid linknamespace
failures, so there are no callers of prctl and we don't need a hidden
alias for it.

>> > Since the the U marker can only be applied to 2 unsigned long arguments,
>> > add a C wrapper for prctl, process_vm_readv and process_vm_writev syscals
>> > which have more than 2 unsigned long arguments.
>>
>> Please add that syscalls.list reference.  Thanks.
>>
>
> I have
>
> ---
> Since the the U marker can only be applied to 2 unsigned long arguments
> in syscalls.list files, add a C wrapper for prctl, process_vm_readv and
> process_vm_writev syscals which have more than 2 unsigned long arguments.
> ---

Nice.

Thanks,
Florian