From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 8320138930C3 for ; Wed, 29 Apr 2020 15:35:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8320138930C3 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-_O6g39E_O9WtLllQ5K_0Yg-1; Wed, 29 Apr 2020 11:35:07 -0400 X-MC-Unique: _O6g39E_O9WtLllQ5K_0Yg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B23E45F; Wed, 29 Apr 2020 15:35:06 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-9.ams2.redhat.com [10.36.114.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9653D605DD; Wed, 29 Apr 2020 15:35:05 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: GNU C Library Subject: Re: V2 [PATCH 2/2] Add C wrappers for prctl/process_vm_readv/process_vm_writev [BZ #25810] References: <20200429144727.3769136-1-hjl.tools@gmail.com> <20200429144727.3769136-2-hjl.tools@gmail.com> <87d07qs5n4.fsf@oldenburg2.str.redhat.com> <20200429152017.GA3811691@gmail.com> <87o8raqpu1.fsf@oldenburg2.str.redhat.com> Date: Wed, 29 Apr 2020 17:35:04 +0200 In-Reply-To: (H. J. Lu's message of "Wed, 29 Apr 2020 08:29:25 -0700") Message-ID: <87ees6qp93.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_BL, RCVD_IN_MSPIKE_L3, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:35:10 -0000 * H. J. Lu: > With > > extern int __prctl (int __option, ...); > libc_hidden_proto (__prctl) > libc_hidden_proto (prctl) > > and > > #include > #include > #include > #include > > int > __prctl (int option, unsigned long int arg2, unsigned long int arg3, > unsigned long int arg4, unsigned long int arg5) > { > return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5); > } > > libc_hidden_def (__prctl) > weak_alias (__prctl, prctl) > hidden_weak (prctl) Please try: extern int __prctl (int __option, ...); libc_hidden_proto (__prctl) And: int __prctl (int option, unsigned long int arg2, unsigned long int arg3, unsigned long int arg4, unsigned long int arg5) { return INLINE_SYSCALL_CALL (prctl, option, arg2, arg3, arg4, arg5); } libc_hidden_def (__prctl) strong_alias (__prctl, prctl) Internal users should always use __prctl to avoid linknamespace failures, so there are no callers of prctl and we don't need a hidden alias for it. >> > Since the the U marker can only be applied to 2 unsigned long argument= s, >> > add a C wrapper for prctl, process_vm_readv and process_vm_writev sysc= als >> > which have more than 2 unsigned long arguments. >> >> Please add that syscalls.list reference. Thanks. >> > > I have > > --- > Since the the U marker can only be applied to 2 unsigned long arguments > in syscalls.list files, add a C wrapper for prctl, process_vm_readv and > process_vm_writev syscals which have more than 2 unsigned long arguments. > --- Nice. Thanks, Florian