From: Luke Shumaker <lukeshu@lukeshu.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
Date: Mon, 01 Jan 2018 02:28:00 -0000 [thread overview]
Message-ID: <87efnawbvh.wl-lukeshu@lukeshu.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1801010127360.28505@digraph.polyomino.org.uk>
On Sun, 31 Dec 2017 20:30:16 -0500,
Joseph Myers wrote:
> On Wed, 27 Dec 2017, Dmitry V. Levin wrote:
>
> > > > > It's a restricted environment.
> > > >
> > > > I don't think the glibc test suite is supposed to pass in such an
> > > > environment.
> > >
> > > It used to work perfectly for at least 15 years, and it still works
> > > when tst-ttyname is fixed.
> >
> > As tst-ttyname was backported to 2.26 stable branch recently, it
> > introduced this test suite regression there, too, so a fix to tst-ttyname
> > should also be backported.
>
> I'm more concerned that we still have the failure on Ubuntu 16.04 noted in
> <https://sourceware.org/ml/libc-alpha/2017-11/msg00832.html>, than about
> failures in a particular restricted environment. Generally, if there are
> known unresolved issues around a patch on master, that's evidence it would
> be premature to backport it to a stable branch. (Note: I haven't actually
> verified if the failure on Ubuntu 16.04 is now present on the release
> branch.)
Yikes! I didn't notice that reply. I've just downloaded the Ubuntu
16.04.3 ISO and will look in to that in the next few days.
--
Happy hacking,
~ Luke Shumaker
next prev parent reply other threads:[~2018-01-01 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 11:48 Dmitry V. Levin
2017-12-25 18:19 ` Florian Weimer
2017-12-25 19:13 ` Dmitry V. Levin
2017-12-25 20:10 ` Zack Weinberg
2017-12-25 21:01 ` Dmitry V. Levin
2017-12-25 21:19 ` Zack Weinberg
2017-12-25 21:39 ` Dmitry V. Levin
2017-12-26 13:07 ` Florian Weimer
2017-12-26 13:53 ` Dmitry V. Levin
2017-12-26 23:07 ` Dmitry V. Levin
2018-01-01 1:30 ` Joseph Myers
2018-01-01 2:28 ` Luke Shumaker [this message]
2017-12-29 14:20 ` Florian Weimer
2017-12-29 14:49 ` Dmitry V. Levin
2018-01-02 5:19 ` [PATCH v3] tst-ttyname: skip the test if failed to become root Luke Shumaker
2017-12-30 23:09 ` Luke Shumaker
2017-12-31 0:11 ` Dmitry V. Levin
2017-12-26 14:10 Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efnawbvh.wl-lukeshu@lukeshu.com \
--to=lukeshu@lukeshu.com \
--cc=joseph@codesourcery.com \
--cc=ldv@altlinux.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).