public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: Shawn Landden <slandden@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] inet: add uint64_t accessors to in6_addr union
Date: Sun, 12 Nov 2017 07:27:00 -0000	[thread overview]
Message-ID: <87efp4t0qw.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20171112065412.18641-1-slandden@gmail.com> (Shawn Landden's message of "Sat, 11 Nov 2017 22:54:12 -0800")

* Shawn Landden:

> diff --git a/inet/netinet/in.h b/inet/netinet/in.h
> index f94b4b4e1c..72d5dec312 100644
> --- a/inet/netinet/in.h
> +++ b/inet/netinet/in.h
> @@ -215,11 +215,13 @@ struct in6_addr
>  	uint8_t	__u6_addr8[16];
>  	uint16_t __u6_addr16[8];
>  	uint32_t __u6_addr32[4];
> +	uint64_t __u6_addr64[2];
>        } __in6_u;

I believe this breaks ABI because it changes the alignment of struct
in6_addr.

  reply	other threads:[~2017-11-12  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-12  6:56 Shawn Landden
2017-11-12  7:27 ` Florian Weimer [this message]
     [not found]   ` <CA+49okotoe+0VvCU0EJb19yWnV=VXrsSSSDkX4PexvKuZij3ew@mail.gmail.com>
     [not found]     ` <CA+49okoai7OHhtHkMAUoBBDq_howuLb7m1T5xUz15C7S7-oxhg@mail.gmail.com>
2017-11-12 11:03       ` Shawn Landden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efp4t0qw.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=libc-alpha@sourceware.org \
    --cc=slandden@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).