From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v3 2/5] powerpc: Add redirection for finitef128, isinf128, and isnanf128
Date: Tue, 19 Sep 2017 13:28:00 -0000 [thread overview]
Message-ID: <87efr2izs5.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170912123435.6592-3-gabriel@inconstante.eti.br>
"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:
> On powerpc64le, compiler support for float128 is not enabled by default
> on gcc. To enable it, the flag -mfloat128 must be passed as a command
> line option to the compiler. This means that only the few files that
> actively have -mfloat128 passed as an argument get compiler support for
> float128, whereas all other files don't.
>
> When -mfloat128 becomes enabled by default on powerpc [1], all the files
> that do not currently have compiler support for float128 enabled during
> their compilation, will start to have it. This will lead to build
> errors in s_finite.c, s_isinf.c, and s_isnan.c.
>
> The errors are due to the unintended macro expansion of __finitef128 to
> __redirect_finitef128 in math/bits/mathcalls-helper-functions.h. In
AFAIU, the expansion of __finitef128 to __redirect_finitef128 in
math/bits/mathcalls-helper-functions.h is expected. The problem happens when
the same thing doesn't happen in include/math.h too.
In that case, I suggest to rewrite this part as:
The errors are due to the macro expansion of __finitef128 to
__redirect_finitef128 in math/bits/mathcalls-helper-functions.h without
expanding it in include/math.h too.
> diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c
> index a5ec36b72f..0382bfb95c 100644
> --- a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c
> +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_finite.c
> @@ -17,8 +17,15 @@
> <http://www.gnu.org/licenses/>. */
>
> #define __finite __redirect___finite
> +
> +/* The following definitions, although not related to the 'double'
> + version of 'finite', are required to compensate for the unintended
> + macro expansion of __finitef to __redirect___finitef, etc. in
> + math/bits/mathcalls-helper-functions.h. */
Likewise.
I suggest the following change:
/* The following definitions, although not related to the 'double'
version of 'finite', are required to guarantee the macro expansion
of __finitef to __redirect___finitef, etc. in
math/bits/mathcalls-helper-functions.h and include/math.h. */
> #define __finitef __redirect___finitef
> #define __finitel __redirect___finitel
> +#define __finitef128 __redirect___finitef128
> +
> #include <math.h>
> #include <math_ldbl_opt.h>
> #include <shlib-compat.h>
Don't you have to undefine this macro later in this file?
--
Tulio Magno
next prev parent reply other threads:[~2017-09-19 13:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 12:34 [PATCH v3 0/5] Fixes for gcc enabling -mfloat128 by default Gabriel F. T. Gomes
2017-09-12 12:34 ` [PATCH v3 1/5] powerpc64le: Add -mfloat128 to tst-strtod-nan-locale testcase Gabriel F. T. Gomes
2017-09-18 20:45 ` Tulio Magno Quites Machado Filho
2017-09-12 12:34 ` [PATCH v3 2/5] powerpc: Add redirection for finitef128, isinf128, and isnanf128 Gabriel F. T. Gomes
2017-09-19 13:28 ` Tulio Magno Quites Machado Filho [this message]
2017-09-19 15:12 ` Gabriel F. T. Gomes
2017-09-20 13:46 ` Tulio Magno Quites Machado Filho
2017-09-12 12:35 ` [PATCH v3 3/5] ldbl-128ibm: Copy implementations from ldbl-128 instead of including them Gabriel F. T. Gomes
2017-09-12 14:41 ` Joseph Myers
2017-09-12 12:35 ` [PATCH v3 4/5] ldbl-128ibm: Automatic replacing of _Float128 and L() Gabriel F. T. Gomes
2017-09-12 14:43 ` Joseph Myers
2017-09-12 12:35 ` [PATCH v3 5/5] Remove conditional on LDBL_MANT_DIG from e_lgammal_r.c Gabriel F. T. Gomes
2017-09-12 14:43 ` Joseph Myers
2017-09-21 21:31 ` [PATCH v3 0/5] Fixes for gcc enabling -mfloat128 by default Gabriel F. T. Gomes
2017-09-22 18:43 ` Tulio Magno Quites Machado Filho
2017-09-26 6:13 ` Florian Weimer
2017-10-09 14:10 ` Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efr2izs5.fsf@linux.vnet.ibm.com \
--to=tuliom@linux.vnet.ibm.com \
--cc=gabriel@inconstante.eti.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).