From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110324 invoked by alias); 27 Dec 2016 19:56:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 110304 invoked by uid 89); 27 Dec 2016 19:56:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=shorter, power8 X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Rajalakshmi Srinivasaraghavan , libc-alpha@sourceware.org Cc: Subject: Re: [PATCH] powerpc64: strchr/strchrnul optimization for power8 In-Reply-To: <1478592744-15714-1-git-send-email-raji@linux.vnet.ibm.com> References: <1478592744-15714-1-git-send-email-raji@linux.vnet.ibm.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Tue, 27 Dec 2016 19:56:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16122719-0024-0000-0000-0000013FA007 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16122719-0025-0000-0000-00001603AB85 Message-Id: <87eg0t5epa.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-27_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1612270320 X-SW-Source: 2016-12/txt/msg01005.txt.bz2 Rajalakshmi Srinivasaraghavan writes: > The P7 code is used for <=32B strings and for > 32B vectorized loops are used. > This shows as an average 25% improvement depending on the position of search > character. The performance is same for shorter strings. > Tested on ppc64 and ppc64le. > > 2016-11-08 Rajalakshmi Srinivasaraghavan > > * sysdeps/powerpc/powerpc64/multiarch/Makefile > (sysdep_routines): Add strchr-power8 and strchrnul_power8. > * sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c > (strchr): Add __strchr_power8 to list of strchr functions. > (strchrnul): Add __strchrnul_power8 to list of strchr functions. > * sysdeps/powerpc/powerpc64/multiarch/strchr-power8.S: New file. > * sysdeps/powerpc/powerpc64/multiarch/strchrnul-power8.S: New file. > * sysdeps/powerpc/powerpc64/multiarch/strchr.c > (strchr): Add __strchr_power8 to ifunc list. > * sysdeps/powerpc/powerpc64/multiarch/strchrnul.c > (__strchrnul): Add __strchrnul_power8 to ifunc list. > * sysdeps/powerpc/powerpc64/power8/strchr.S: New file. > * sysdeps/powerpc/powerpc64/power8/strchrnul.S: New file. LGTM. -- Tulio Magno