From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Cc: munroesj@linux.vnet.ibm.com
Subject: Re: Fix cmpli usage in power6 memset
Date: Tue, 25 Oct 2016 15:44:00 -0000 [thread overview]
Message-ID: <87eg34xwll.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1610242200430.26381@digraph.polyomino.org.uk>
Joseph Myers <joseph@codesourcery.com> writes:
> Building glibc for powerpc64 with recent (2.27.51.20161012) binutils,
> with multi-arch enabled, I get the error:
>
> ../sysdeps/powerpc/powerpc64/power6/memset.S: Assembler messages:
> ../sysdeps/powerpc/powerpc64/power6/memset.S:254: Error: operand out of range (5 is not between 0 and 1)
> ../sysdeps/powerpc/powerpc64/power6/memset.S:254: Error: operand out of range (128 is not between 0 and 31)
> ../sysdeps/powerpc/powerpc64/power6/memset.S:254: Error: missing operand
>
> Indeed, cmpli is documented as a four-operand instruction, and looking
> at nearby code it seems likely cmpldi was intended. This patch fixes
> this powerpc64 code accordingly, and makes a corresponding change to
> the powerpc32 code.
>
> Note: this patch is not tested beyond verifying that the powerpc64
> code builds where it failed to build before the patch. In particular,
> I have not done execution testing
Tested on powerpc, powerpc64 and powerpc64le.
LGTM.
> (the systems I usually use for
> testing powerpc are pre-power6 so wouldn't use this code) or tested
> the powerpc32 change.
In case you want to have access to POWER8 servers, some universities provide
free access to virtual machines for the open source community:
- MiniCloud - State University of Campinas (Unicamp), Brazil
http://openpower.ic.unicamp.br/minicloud/
- Open Power Hub - Brno University of Technology, Czech Republic
http://fit-rhlab.rhcloud.com/powerlinux-openpower-development-hosting/
- OSU Open Source Lab - Oregon State University, US
http://osuosl.org/services/powerdev/
- SuperVessel - IBM China
https://ptopenlab.com/cloudlabconsole
--
Tulio Magno
next prev parent reply other threads:[~2016-10-25 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 22:04 Joseph Myers
2016-10-25 15:44 ` Tulio Magno Quites Machado Filho [this message]
2016-10-25 16:12 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg34xwll.fsf@linux.vnet.ibm.com \
--to=tuliom@linux.vnet.ibm.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=munroesj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).