From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102282 invoked by alias); 14 Mar 2016 23:36:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 102268 invoked by uid 89); 14 Mar 2016 23:36:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=rounds, rights X-HELO: mail.esperi.org.uk From: Nix To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 16/17 v5] x86, pthread_cond_*wait: Do not depend on %eax not being clobbered References: <1457882222-22599-1-git-send-email-nix@esperi.org.uk> <1457882222-22599-17-git-send-email-nix@esperi.org.uk> <56E71890.7010501@redhat.com> Date: Mon, 14 Mar 2016 23:36:00 -0000 In-Reply-To: <56E71890.7010501@redhat.com> (Florian Weimer's message of "Mon, 14 Mar 2016 21:01:20 +0100") Message-ID: <87egbchbt5.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC-x.dcc-servers-Metrics: spindle 104; Body=2 Fuz1=2 Fuz2=2 X-SW-Source: 2016-03/txt/msg00413.txt.bz2 On 14 Mar 2016, Florian Weimer said: > On 03/13/2016 04:17 PM, Nix wrote: >> From: Nick Alcock > >> * sysdeps/unix/sysv/linux/i386/pthread_cond_timedwait.S: Reload >> call-clobbered %eax on retry path. >> * sysdeps/unix/sysv/linux/i386/pthread_cond_wait.S: Likewise. > > Looks good. Can you commit this yourself, or do you need someone to > commit it for you? I don't have commit rights, so if you or someone else wants to commit it, commit away! (and if anyone has any more comments on the rest of the patch, do fire away with slings and arrows etc. I'd hope it's converging on something acceptable after this many rounds... :) ) -- NULL && (void)