public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Change ldconfig auxcache magic number (bug 32231)
Date: Thu, 24 Oct 2024 20:25:11 +0200	[thread overview]
Message-ID: <87frolz7co.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <4a54d387-c903-4c25-97c7-3f6a09cb849d@linaro.org> (Adhemerval Zanella Netto's message of "Thu, 24 Oct 2024 14:43:38 -0300")

* Adhemerval Zanella Netto:

> On 24/10/24 02:52, Florian Weimer wrote:
>> In commit c628c2296392ed3bf2cb8d8470668e64fe53389f (elf: Remove
>> ldconfig kernel version check), the layout of auxcache entries
>> changed because the osversion field was removed from
>> struct aux_cache_file_entry.  However, AUX_CACHEMAGIC was not
>> changed, so existing files are still used, potentially leading
>> to unintended ldconfig behavior.  This commit changes AUX_CACHEMAGIC,
>> so that the file is regenerated.
>> 
>> Tested on x86_64-linux-gnu.  Verified manually that the early exit in
>> load_aux_cache is taken due to the change in file magic.
>> 
>> Reported-by: DJ Delorie <dj@redhat.com>
>
> Ouch, I should have know better about this one.  I think it is too late
> to backport this now.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Thanks.

I don't see a problem with backparting this.  It just triggers
unnecessary auxcache regeneration on upgrades/downgrades between
compatible versions.  But it will fix the update across incompatible
versions.

Thanks,
Florian


      reply	other threads:[~2024-10-24 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24  5:52 Florian Weimer
2024-10-24 17:43 ` Adhemerval Zanella Netto
2024-10-24 18:25   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frolz7co.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).