From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A6CDB3858C41 for ; Thu, 13 Jul 2023 09:51:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6CDB3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689241903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aOfJnnBDzicfDk23uOMqikB9oeVAArtYrIKS9jGxbbk=; b=KTB3J+7c+Zphcl/SsrJsHvfRo4ftavAhcziO8Uz2wls7bvoHvF2iXpOpYf5Hf2bF3oJ9st Ux3Yzq/UzPhyfAZeIYKcByYc2NjwNVCXlX1XhqTCt1HgLbzUsMrs+N0FYwB3jj6cG7DbIp a0BNPz0+GRArKHlG0N7WSPIAIRB9OTI= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-519-7ExzQGy5M9egiZhFE0v7dg-1; Thu, 13 Jul 2023 05:51:41 -0400 X-MC-Unique: 7ExzQGy5M9egiZhFE0v7dg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A8FA2999B3D; Thu, 13 Jul 2023 09:51:41 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52418200AD6E; Thu, 13 Jul 2023 09:51:40 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar via Libc-alpha Cc: Siddhesh Poyarekar Subject: Re: [PATCH v2 2/4] configure: Default --enable-stack-protector to strong References: <20230629184156.2789945-1-siddhesh@sourceware.org> <20230630014248.2819836-1-siddhesh@sourceware.org> <20230630014248.2819836-3-siddhesh@sourceware.org> Date: Thu, 13 Jul 2023 11:51:38 +0200 In-Reply-To: <20230630014248.2819836-3-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Thu, 29 Jun 2023 21:42:44 -0400") Message-ID: <87fs5syw9h.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Siddhesh Poyarekar via Libc-alpha: > All major distributions use this level of stack protector, so make it > the default. > > Signed-off-by: Siddhesh Poyarekar I think if strong is the default (correct IMHO), it should be the default for --enable-stack-protector, too. I'm not sure if we need to support legacy -fstack-protector at all, but we do, we'd need a separate option argument. I would expect some build-many-glibcs.py updates for this one, too. But I think for this one, --disable-stack-protector actually works. Thanks, Florian