From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org, alx.manpages@gmail.com
Subject: Re: [PATCH v2 2/2] Add lint-makefiles Makefile linting test.
Date: Tue, 30 May 2023 14:25:34 +0200 [thread overview]
Message-ID: <87fs7et39d.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230530120759.2150593-2-carlos@redhat.com> (Carlos O'Donell's message of "Tue, 30 May 2023 08:07:59 -0400")
* Carlos O'Donell:
> +echo "Linting Makefiles:"
> +echo "Check: Are all lines sorted correctly?"
Maybe don't print anything if there isn't an error?
> +linted=0
> +for mfile in `find "$srcdir" -name Makefile`; do
> + echo "$mfile"
> + $PYTHON "${srcdir}/scripts/sort-makefile-lines.py" < "$mfile" > "$tmpfile"
> + diff -q "$mfile" "$tmpfile"
Please use diff -u, make the diff go from expected to actual (other
direction), use --label to label $tmpfile, and keep going after the
first failure.
Thanks,
Florian
next prev parent reply other threads:[~2023-05-30 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:07 [PATCH v2 1/2] elf: Sort Makefile variables Carlos O'Donell
2023-05-30 12:07 ` [PATCH v2 2/2] Add lint-makefiles Makefile linting test Carlos O'Donell
2023-05-30 12:25 ` Florian Weimer [this message]
2023-05-30 13:02 ` Carlos O'Donell
2023-05-30 12:20 ` [PATCH v2 1/2] elf: Sort Makefile variables Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs7et39d.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=alx.manpages@gmail.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).