From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xBen=BT=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id 931153858D20
	for <libc-alpha@sourceware.org>; Tue, 30 May 2023 12:25:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 931153858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1685449539;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CpqUixQSWXvqz7dx+2TqYeqYV+kBr3lfg+nLt6xZVbo=;
	b=hhXng1cRF0Cz8hQgRhgIALidIBgxb+ZI4ASt4W+Z+YVLhjRLUz0oSomYdYu4DibhXRpn4C
	CLUrBK0/4vf3vi/Bg+AqwnepxDHwzjZYxxPjVrRC2OI3MfAQz3ED9rVyYcyi50Ada1Z3MP
	Oyi/khe5PB+LtCOa6nDHoow1iQXu4mE=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-211-_YA7IWNmMDmQpxGIw7rPGA-1; Tue, 30 May 2023 08:25:37 -0400
X-MC-Unique: _YA7IWNmMDmQpxGIw7rPGA-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B4323C1350D;
	Tue, 30 May 2023 12:25:37 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.38])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C93E62166B25;
	Tue, 30 May 2023 12:25:36 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org,  alx.manpages@gmail.com
Subject: Re: [PATCH v2 2/2] Add lint-makefiles Makefile linting test.
References: <20230530120759.2150593-1-carlos@redhat.com>
	<20230530120759.2150593-2-carlos@redhat.com>
Date: Tue, 30 May 2023 14:25:34 +0200
In-Reply-To: <20230530120759.2150593-2-carlos@redhat.com> (Carlos O'Donell's
	message of "Tue, 30 May 2023 08:07:59 -0400")
Message-ID: <87fs7et39d.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Carlos O'Donell:

> +echo "Linting Makefiles:"
> +echo "Check: Are all lines sorted correctly?"

Maybe don't print anything if there isn't an error?

> +linted=0
> +for mfile in `find "$srcdir" -name Makefile`; do
> +    echo "$mfile"
> +    $PYTHON "${srcdir}/scripts/sort-makefile-lines.py" < "$mfile" > "$tmpfile"
> +    diff -q "$mfile" "$tmpfile"

Please use diff -u, make the diff go from expected to actual (other
direction), use --label to label $tmpfile, and keep going after the
first failure.

Thanks,
Florian