From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3B48E3858D28 for ; Thu, 25 May 2023 07:46:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B48E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685000779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n5TUj1NbtV96vffgFHxHls2bkl1o8gxOLGFJSwLvsRM=; b=d6MaN2/+w/4R1X+iJiw+wdFmYdbPaJ052KMXX6ssMg7a0j5xF2+vRJRCF8sc8+ivwZIyrV g3c6BPYA6Y+0frzV54xdImpTFnBnHZ3dAtOwtgo/bg1p51DTZe+0Q5jIEN/UvzDj7vBAh5 j0BacphhyG4FbqJbRbkiY4yfygaTQSw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-hbJ9BQHjOLmg3c0v3nn_0Q-1; Thu, 25 May 2023 03:46:16 -0400 X-MC-Unique: hbJ9BQHjOLmg3c0v3nn_0Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B7793823A0C; Thu, 25 May 2023 07:46:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B0F42023273; Thu, 25 May 2023 07:46:14 +0000 (UTC) From: Florian Weimer To: Roy Eldar via Libc-alpha Cc: Roy Eldar , carlos@redhat.com Subject: Re: [PATCH] elf: fix handling of negative numbers in dl-printf References: <20230503211641.5742-1-royeldar0@gmail.com> Date: Thu, 25 May 2023 09:46:13 +0200 In-Reply-To: <20230503211641.5742-1-royeldar0@gmail.com> (Roy Eldar via Libc-alpha's message of "Thu, 4 May 2023 00:16:41 +0300") Message-ID: <87fs7kq2ey.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Roy Eldar via Libc-alpha: > _dl_debug_vdprintf is a bare-bones printf implementation; currently > printing a signed integer (using "%d" format specifier) behaves > incorrectly when the number is negative, as it just prints the > corresponding unsigned integer, preceeded by a minus sign. > > For example, _dl_printf("%d", -1) would print '-4294967295'. > > Signed-off-by: Roy Eldar > --- > elf/dl-printf.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/elf/dl-printf.c b/elf/dl-printf.c > index e8b9900370..977ac330b6 100644 > --- a/elf/dl-printf.c > +++ b/elf/dl-printf.c Please update the copyright staement with Copyright The GNU Toolchain Authors. Then I'm going to apply it together with the test. Thanks, Florian