From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 833F53858D39 for ; Tue, 7 Mar 2023 11:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 833F53858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678189336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jhE9NC9tgB9+d81k5gZLZCX1hKjTnfV7TgsgmS3qC/0=; b=NpiIUH2Z+cE2EYa+MO3qppQzLWBhdoHXG4qd/8OirnyiCPfmExVCMpf7gbqt6FxsTYUtu6 A28WhXOrnahrRZlGJoTATkzgGKZoZDrEvnCgsDpF4ViYm/7H9X6tG6jjZzcyGn1zMJLIeT ImPuEYgNSCAsucHjFGQMVW17e03DDPo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-295-LmlAvEDMMiqDVUe8-lo68A-1; Tue, 07 Mar 2023 06:42:14 -0500 X-MC-Unique: LmlAvEDMMiqDVUe8-lo68A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8258485CBE9; Tue, 7 Mar 2023 11:42:14 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80DEE2166B2A; Tue, 7 Mar 2023 11:42:13 +0000 (UTC) From: Florian Weimer To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Cc: libc-alpha@sourceware.org, carlos@redhat.com, toolchain@gentoo.org Subject: Re: [PATCH v3 1/2] elf,nptl: Add -z lazy to some more tests References: <20230307102935.2882450-1-arsen@gentoo.org> Date: Tue, 07 Mar 2023 12:42:11 +0100 In-Reply-To: <20230307102935.2882450-1-arsen@gentoo.org> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Tue, 7 Mar 2023 11:29:34 +0100") Message-ID: <87fsagpz3g.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Arsen Arsenovi=C4=87: > Some toolchains, such as that used on Gentoo Hardened, set -z now out of > the box. This trips up a couple of tests. > --- > Hi, > > This is re-roll of the following patch series: > https://inbox.sourceware.org/libc-alpha/20230307003222.2810662-1-arsen@aa= rsen.me/ > https://inbox.sourceware.org/libc-alpha/20230302112519.914641-1-arsen@gen= too.org/ > > Changes from v2: > - Split off the +$(objpfx)resolvfail.out: $(objpfx)testobj1.so change > into its own commit. > > Changes from v1: > - Dropped -z norelro. This turned out to be unnecessary after > Adhemervals removal of --with-default-link and linker script > machinery: > https://patchwork.sourceware.org/project/glibc/list/?series=3D17843 > See: https://inbox.sourceware.org/libc-alpha/86fsakz5mr.fsf@gentoo.org > for an explanation of what caused the need for norelro. That fix was > misguided, due to a previous error on my part, too. > I applied this patch on top of that patchset and it would appear to > resolve all related failures. > The above is not applied to Git yet, but should be before this patch > is. > > elf/Makefile | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > elf/Makefile | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) The patches look okay to me, but would you please resend them with Signed-off-by: (to mark this as a contribution under DCO)? I had the FSF records checked, and they don't have a glibc copyright assignment from you, as far as we can tell. Sorry for the hassle! Thanks, Florian