From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5E23E3858C66 for ; Tue, 7 Mar 2023 09:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E23E3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678179979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vDhypqe12q/21QhL7bJiat6QxfnmwYTJ1j4jlNVcDBw=; b=hZblJOsB0I07EmlY6N1CvzHlepyV1u8t6WvKuIqvINH8Bc+Kjx8K2oU8Z1WYUufiF2f9u8 Rq88s8StWxpJY/hM5EmT9+D7M7PaP2gp8vUOFoU6xaPrB8W88nQUq/rP+mU7y8gBhacKQL itJ7l5TomH+XwAAHhPH4zgsxu8EN2kU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-115-DTx11MaqOYK_PLcoDTOGEg-1; Tue, 07 Mar 2023 04:06:09 -0500 X-MC-Unique: DTx11MaqOYK_PLcoDTOGEg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 09A7C18E0920; Tue, 7 Mar 2023 09:06:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FF1CC15BA0; Tue, 7 Mar 2023 09:06:08 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] gshadow: Matching sgetsgent, sgetsgent_r ERANGE handling (bug 30151) References: <875ybvs98d.fsf@oldenburg.str.redhat.com> <3e3a4797-501d-3df7-c69f-9a715f3f3e0c@gotplt.org> Date: Tue, 07 Mar 2023 10:06:06 +0100 In-Reply-To: <3e3a4797-501d-3df7-c69f-9a715f3f3e0c@gotplt.org> (Siddhesh Poyarekar's message of "Wed, 1 Mar 2023 13:20:22 -0500") Message-ID: <87fsahq6bl.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Siddhesh Poyarekar: > On 2023-02-21 03:39, Florian Weimer via Libc-alpha wrote: >> Before this change, sgetsgent_r did not set errno to ERNAGE, but > > s/ERNAGE/ERANGE/ > >> sgetsgent only checked errno, not the return value from sgetsgent_r. >> Consequently, sgetsgent did not detect any error, and reported >> success to the caller, without initializing the struct sgrp object >> whose address was returned. >> This commit changes sgetsgent_r to set errno as well. This avoids >> similar issues in applications which only change errno. > > ... which only *check* errno? > > The patch itself is fine. > > Reviewed-by: Siddhesh Poyarekar Thanks, pushed. Florian