From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CF12C3858D1E for ; Mon, 6 Feb 2023 06:01:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF12C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675663295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Op+P1T/W7ZljUEejOltZRHw5mcbUxXZkm1FH3lShd2E=; b=fPlFe81+HbZO0+o9MYMiXpBAiTgyC1zqvhxBb6uKXJyZ0IC/Mi/wR+wwAXUHa0/FCr00CD sZvHmwg0CfsfaMAwqnzxIYl1p0DTQnGRAf8N9jW2KZiy/AKD2k/DdJNM4SXHJRSmF1rKOL P7BmVLOe3dMT/2dOPWFwFhJQfPAtjGQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-7YDIhkUROJ2f_D2bkP4BHA-1; Mon, 06 Feb 2023 01:01:32 -0500 X-MC-Unique: 7YDIhkUROJ2f_D2bkP4BHA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A794F299E747; Mon, 6 Feb 2023 06:01:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7635C15BA0; Mon, 6 Feb 2023 06:01:30 +0000 (UTC) From: Florian Weimer To: Paul Pluzhnikov Cc: Jonathan Wakely , Szabolcs Nagy , Rich Felker , Paul Pluzhnikov via Libc-alpha Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert implementation in C++ References: <871qnlfhtv.fsf@oldenburg.str.redhat.com> <20230124111019.GC3298@brightrain.aerifal.cx> <878rhsgoxn.fsf@oldenburg.str.redhat.com> <20230124112307.GE3298@brightrain.aerifal.cx> <87zga8f83f.fsf@oldenburg.str.redhat.com> <871qn3yix8.fsf@oldenburg.str.redhat.com> <87o7q7wxli.fsf@oldenburg.str.redhat.com> Date: Mon, 06 Feb 2023 07:01:29 +0100 In-Reply-To: (Paul Pluzhnikov's message of "Sun, 5 Feb 2023 14:55:10 -0800") Message-ID: <87fsbjwcw6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Paul Pluzhnikov: > On Sun, Feb 5, 2023 at 2:34 PM Florian Weimer wrote: >> >> * Paul Pluzhnikov: >> >> > +# if __has_builtin(__builtin_FILE) >> > +# define __ASSERT_FILE __builtin_FILE() >> > +# define __ASSERT_LINE __builtin_LINE() > > I picked __ASSERT_FILE to match (already used) __ASSERT_FUNCTION. > Mixing __glibc_assert_file with __ASSERT_FUNCTION creates a cognitive > dissonance for me. > > How strongly do you feel about this? Not strongly at all. __ASSERT_FUNCTION is probably okay. >> __has_builtin itself needs to be conditionalized. 8-( > > Revised patch attached. Missing spaces before '(', sorry. Rest looks okay if we can assume that __builtin_FILE and __builtin_LINE are implemented at the same time. Thanks, Florian