Re: [PATCH 07/26] __printf_fphex always uses LC_NUMERIC

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella:

> On 17/03/2022 16:29, Florian Weimer via Libc-alpha wrote:
>> There is no hexadecimal currency printing.  strfmon uses
>> __printf_fp_l exclusively.
>
> LGTM, some comments below.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>
>> ---
>>  stdio-common/printf_fphex.c | 26 +++++++-------------------
>>  1 file changed, 7 insertions(+), 19 deletions(-)
>> 
>> diff --git a/stdio-common/printf_fphex.c b/stdio-common/printf_fphex.c
>> index 3dbbefd972..df11b4a166 100644
>> --- a/stdio-common/printf_fphex.c
>> +++ b/stdio-common/printf_fphex.c
>> @@ -103,9 +103,13 @@ __printf_fphex (FILE *fp,
>>      }
>>    fpnum;
>>  
>> -  /* Locale-dependent representation of decimal point.	*/
>> -  const char *decimal;
>> -  wchar_t decimalwc;
>> +  /* Locale-dependent representation of decimal point. Hexadecimal
>> +     formatting always using LC_NUMERIC (disregarding info->extra).  */
>> +  const char *decimal = _NL_CURRENT (LC_NUMERIC, DECIMAL_POINT);
>> +  wchar_t decimalwc = _NL_CURRENT_WORD (LC_NUMERIC, _NL_NUMERIC_DECIMAL_POINT_WC);
>
> Line too long.

Fixed.

>> +  /* The decimal point character must never be zero.  */
>> +  assert (*decimal != '\0' && decimalwc != L'\0');
>>  
>
> Should we assert for info->extra == 0 ?

I added:

  /* This function always uses LC_NUMERIC.  */
  assert (info->extra == 0);

Thanks,
Florian