From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A0A0B3857433 for ; Wed, 4 May 2022 09:42:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0A0B3857433 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-bGC5tuzJN1aO3f8l50CVnQ-1; Wed, 04 May 2022 05:42:12 -0400 X-MC-Unique: bGC5tuzJN1aO3f8l50CVnQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1DFA529AB40E; Wed, 4 May 2022 09:31:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45FE220290BB; Wed, 4 May 2022 09:31:45 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy via Libc-alpha Cc: Szabolcs Nagy Subject: Re: [PATCH v4 2/4] rtld: Remove DL_ARGV_NOT_RELRO References: <3e12f8fc7eb1050f90fae30b4f20357c638181e6.1651643916.git.szabolcs.nagy@arm.com> Date: Wed, 04 May 2022 11:31:43 +0200 In-Reply-To: <3e12f8fc7eb1050f90fae30b4f20357c638181e6.1651643916.git.szabolcs.nagy@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Wed, 4 May 2022 07:26:54 +0100") Message-ID: <87fslptzi8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 09:42:14 -0000 * Szabolcs Nagy via Libc-alpha: > This is no longer needed because _dl_skip_args is always 0, so the > target specific code that modifies argv after relro protection is > applied is no longer used. > > After the patch relro protection is applied to _dl_argv consistently > on all targets. I double-checked and as far as I can tell, the _dl_argv update is indeed conditional on _dl_skip_args != 0. Maybe you could define _dl_skip_args as const and add a comment that it is there for the benefit of non-yet-ported startup code, but maybe we can clean this up quickly so that it does not matter. Tested on s390-linux-gnu and s390x-linux-gnu, powerpc64le-linux-gnu. Reviewed-by: Florian Weimer Tested-by: Florian Weimer Thanks, Florian