From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DF3D13857418 for ; Tue, 3 May 2022 05:13:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF3D13857418 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-139-LsJG14EeOsG5-YyxYeDapg-1; Tue, 03 May 2022 01:13:10 -0400 X-MC-Unique: LsJG14EeOsG5-YyxYeDapg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59A0B800882; Tue, 3 May 2022 05:13:10 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8257141617C; Tue, 3 May 2022 05:13:09 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar via Libc-alpha Cc: Siddhesh Poyarekar Subject: Re: [PATCH] manual: Clarify that abbreviations of long options are allowed References: <20220503045743.2887439-1-siddhesh@sourceware.org> Date: Tue, 03 May 2022 07:13:07 +0200 In-Reply-To: <20220503045743.2887439-1-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Tue, 3 May 2022 10:27:43 +0530") Message-ID: <87fslrxkpo.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2022 05:13:14 -0000 * Siddhesh Poyarekar via Libc-alpha: > The man page and code comments clearly state that abbreviations of long > option names are recognized correctly as long as they are unique. > Document this fact in the glibc manual as well. > > Signed-off-by: Siddhesh Poyarekar > --- > manual/getopt.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/manual/getopt.texi b/manual/getopt.texi > index 5485fc4694..e58283ab88 100644 > --- a/manual/getopt.texi > +++ b/manual/getopt.texi > @@ -250,7 +250,8 @@ option, and stores the option's argument (if it has one) in @code{optarg}. > > When @code{getopt_long} encounters a long option, it takes actions based > on the @code{flag} and @code{val} fields of the definition of that > -option. > +option. The option name may be abbreviated as long as the abbreviation is > +unique or is an exact match for some defined option. > > If @code{flag} is a null pointer, then @code{getopt_long} returns the > contents of @code{val} to indicate which option it found. You should Looks okay. Reviewed-by: Florian Weimer Thanks, Florian