From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2BBEB3858407 for ; Fri, 17 Dec 2021 16:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2BBEB3858407 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-108-diN_OBDBMSy7cwl5JTgPBw-1; Fri, 17 Dec 2021 11:50:44 -0500 X-MC-Unique: diN_OBDBMSy7cwl5JTgPBw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE95A10B7462; Fri, 17 Dec 2021 16:50:43 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91FE8ADCD; Fri, 17 Dec 2021 16:50:42 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v6 06/20] elf: Add _dl_audit_symbind_alt and _dl_audit_symbind References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-7-adhemerval.zanella@linaro.org> Date: Fri, 17 Dec 2021 17:50:40 +0100 In-Reply-To: <20211115183734.531155-7-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 15 Nov 2021 15:37:20 -0300") Message-ID: <87fsqri3a7.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 16:50:49 -0000 * Adhemerval Zanella: > diff --git a/elf/dl-audit.c b/elf/dl-audit.c > index ef34ff761c..8e4c65fdaf 100644 > --- a/elf/dl-audit.c > +++ b/elf/dl-audit.c > @@ -16,6 +16,7 @@ > +void > +_dl_audit_symbind_alt (struct link_map *l, const ElfW(Sym) *ref, void **= value, > +=09=09 lookup_t result) > +_dl_audit_symbind (struct link_map *l, struct reloc_result *reloc_result= , > +=09=09 const ElfW(Sym) *defsym, DL_FIXUP_VALUE_TYPE *value, > +=09=09 lookup_t result) > +{ The call to _dl_audit_symbind is added in patch 10 of the series (=E2=80=9C= elf: Avoid unnecessary slowdown from profiling with audit (BZ#15533)=E2=80=9D). But I would expected this patch here to replace the copy in elf/dl-runtime.c. Thanks, Florian