From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2CBB23858426 for ; Thu, 9 Dec 2021 12:34:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CBB23858426 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-38-Om7ES3acNcecN5grpnCOIg-1; Thu, 09 Dec 2021 07:34:45 -0500 X-MC-Unique: Om7ES3acNcecN5grpnCOIg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A828100CE83; Thu, 9 Dec 2021 12:34:44 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B83C81B472; Thu, 9 Dec 2021 12:34:43 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 7/8] nptl: Add public rseq symbols and References: <67665bb0d00cd540def5bfe758c94c98458536df.1638880889.git.fweimer@redhat.com> <20211209122624.GO3294453@arm.com> Date: Thu, 09 Dec 2021 13:34:42 +0100 In-Reply-To: <20211209122624.GO3294453@arm.com> (Szabolcs Nagy's message of "Thu, 9 Dec 2021 12:26:24 +0000") Message-ID: <87fsr2gdnh.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 12:34:50 -0000 * Szabolcs Nagy: > The 12/07/2021 14:03, Florian Weimer via Libc-alpha wrote: >> diff --git a/sysdeps/unix/sysv/linux/tst-rseq.c b/sysdeps/unix/sysv/linux/tst-rseq.c >> index 926376b6a5..572c11166f 100644 >> --- a/sysdeps/unix/sysv/linux/tst-rseq.c >> +++ b/sysdeps/unix/sysv/linux/tst-rseq.c >> @@ -29,12 +29,20 @@ >> # include >> # include >> # include >> +# include >> +# include >> # include "tst-rseq.h" >> >> static void >> do_rseq_main_test (void) >> { >> + struct pthread *pd = THREAD_SELF; >> + >> TEST_VERIFY_EXIT (rseq_thread_registered ()); >> + TEST_COMPARE (__rseq_flags, 0); >> + TEST_VERIFY ((char *) __thread_pointer () + __rseq_offset >> + == (char *) &pd->rseq_area); >> + TEST_COMPARE (__rseq_size, sizeof (pd->rseq_area)); >> } > > sorry i just tested the committed patches on 32bit arm > (on 64bit kernel) and there is a tls alignment issue > > FAIL: nptl/tst-tls3 > FAIL: nptl/tst-tls3-malloc > FAIL: nptl/tst-tls5 > > outputs: > > initial thread's struct pthread not aligned enough > initial thread's struct pthread not aligned enough > pthread_self () = 0xf7e2d350, size 1408, align 32, WRONG ALIGNMENT > > and rseq registration fails with EINVAL causing > > FAIL: misc/tst-rseq I missed that we have both TCB_ALIGNMENT and TLS_TCB_ALIGN. I think we need to remove the latter. I will try to work on a patch later today. Thanks, Florian