From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A619C3858D39 for ; Fri, 26 Nov 2021 21:30:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A619C3858D39 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AQLM1Qh024640; Fri, 26 Nov 2021 21:30:52 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com with ESMTP id 3ck7ebr3j4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Nov 2021 21:30:52 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1AQLJMJJ000895; Fri, 26 Nov 2021 21:30:51 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma05wdc.us.ibm.com with ESMTP id 3cerncrtwr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Nov 2021 21:30:51 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1AQLUoha57541090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Nov 2021 21:30:50 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 84945112063; Fri, 26 Nov 2021 21:30:50 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75F75112061; Fri, 26 Nov 2021 21:30:49 +0000 (GMT) Received: from TP480.linux.ibm.com (unknown [9.160.29.215]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 26 Nov 2021 21:30:49 +0000 (GMT) References: <20211124132912.175073-1-msc@linux.ibm.com> <871r35ir2u.fsf@igel.home> User-agent: mu4e 1.6.6; emacs 27.2 From: Matheus Castanho To: Andreas Schwab Cc: Matheus Castanho via Libc-alpha , murphyp@linux.ibm.com Subject: Re: [PATCH v2] powerpc64[le]: Fix CFI and LR save address for asm syscalls [BZ #28532] Date: Fri, 26 Nov 2021 18:29:39 -0300 In-reply-to: <871r35ir2u.fsf@igel.home> Message-ID: <87fsrimwon.fsf@linux.ibm.com> Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oSZ8ZDc98eLpdSdmMxWfy0m1EGY1WM4m X-Proofpoint-ORIG-GUID: oSZ8ZDc98eLpdSdmMxWfy0m1EGY1WM4m X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-26_06,2021-11-25_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111260123 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 21:30:56 -0000 Andreas Schwab writes: > On Nov 24 2021, Matheus Castanho via Libc-alpha wrote: > >> diff --git a/sysdeps/powerpc/powerpc64/sysdep.h b/sysdeps/powerpc/powerpc64/sysdep.h >> index 589f7c8d18..c751bc76f9 100644 >> --- a/sysdeps/powerpc/powerpc64/sysdep.h >> +++ b/sysdeps/powerpc/powerpc64/sysdep.h >> @@ -275,12 +275,14 @@ LT_LABELSUFFIX(name,_name_end): ; \ >> /* Allocate frame and save register */ >> #define NVOLREG_SAVE \ >> stdu r1,-SCV_FRAME_SIZE(r1); \ >> + cfi_adjust_cfa_offset(SCV_FRAME_SIZE); \ >> std r31,SCV_FRAME_NVOLREG_SAVE(r1); \ >> - cfi_adjust_cfa_offset(SCV_FRAME_SIZE); >> + cfi_offset(r31,-(SCV_FRAME_SIZE-SCV_FRAME_NVOLREG_SAVE)); > > Perhaps use cfi_rel_offset instead. Thanks, that's much cleaner. I included that on v3 [1] [1] https://sourceware.org/pipermail/libc-alpha/2021-November/133491.html -- Matheus Castanho