public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Arjun Shankar via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] test-container: Set /bin up as a symbolic link to /usr/bin
Date: Fri, 12 Nov 2021 13:25:11 +0100	[thread overview]
Message-ID: <87fss1sgrc.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211112104142.GA30371@lostca.se> (Arjun Shankar via Libc-alpha's message of "Fri, 12 Nov 2021 10:41:42 +0000")

* Arjun Shankar via Libc-alpha:

> From: Arjun Shankar <arjun@redhat.com>
>
> This makes the container environment more compatible with various
> operating systems.
>
> For example, prior to this commit tst-vfork3 would fail when building
> the glibc package for RHEL 9.  This was because _CS_PATH is "/usr/bin"
> there instead of the default "/bin:/usr/bin", causing the test to try
> to execute /usr/bin/echo in the container where echo was located in /bin
> instead.  While this could be fixed in the test itself, this commit
> seems like a more general solution.

Thank you for this analysis.

I think this is just a broken downstream patch.  We should fix this
downstream for now, probably adding the symbolic links our installation
has to the containers.

We need real UsrMove support in glibc, as a configure-time option.  This
would activate the _CS_PATH change in our downstream patch, change the
default library search path, alter the installation paths (and probably
create the symbolic links if they do not exist), and make sure that the
test containers match the installation tree.

Thanks,
Florian


      reply	other threads:[~2021-11-12 12:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 10:41 Arjun Shankar
2021-11-12 12:25 ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fss1sgrc.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).