From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 13AD63939C1B for ; Thu, 17 Jun 2021 12:19:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 13AD63939C1B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4G5Lj56f62z1s3jg; Thu, 17 Jun 2021 14:19:53 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4G5Lj55gkSz1qrk4; Thu, 17 Jun 2021 14:19:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ZYcA5gYPUGNp; Thu, 17 Jun 2021 14:19:53 +0200 (CEST) X-Auth-Info: zQOE8pRthF6/HhAL5b8oZqTzmWRzKma31OZwve0yrtwnPhhdx41Goy+7fdFJsL/E Received: from igel.home (ppp-46-244-187-91.dynamic.mnet-online.de [46.244.187.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 17 Jun 2021 14:19:52 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 6801A2C3629; Thu, 17 Jun 2021 14:19:52 +0200 (CEST) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 02/18] Use LFS and 64 bit time for installed programs References: <20210617115104.1359598-1-adhemerval.zanella@linaro.org> <20210617115104.1359598-3-adhemerval.zanella@linaro.org> X-Yow: A can of ASPARAGUS, 73 pigeons, some LIVE ammo, and a FROZEN DAQUIRI!! Date: Thu, 17 Jun 2021 14:19:52 +0200 In-Reply-To: <20210617115104.1359598-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 17 Jun 2021 08:50:48 -0300") Message-ID: <87fsxgn0nr.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 12:19:56 -0000 On Jun 17 2021, Adhemerval Zanella via Libc-alpha wrote: > diff --git a/Makeconfig b/Makeconfig > index 6482a43025..de30ba3fa6 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -851,6 +851,10 @@ endif > # -fno-math-errno. > +extra-math-flags = $(if $(filter libm,$(in-module)),-fno-math-errno,-fmath-errno) > > +# Use 64 bit time_t support for installed programs > ++extra-time-flags = $(if $(filter nonlib nscd lddlibc4 ldconfig locale_programs iconvprogs,\ I'd suggest to put the list of module names in a variable, to make it easier to shorten the line. > diff --git a/Makerules b/Makerules > index 12f1a5cb50..770a573134 100644 > --- a/Makerules > +++ b/Makerules > @@ -1313,14 +1313,22 @@ lib := testsuite > include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left)) > endif > > -all-nonlib := $(strip $(tests-internal) $(test-internal-extras) \ > - $(others) $(others-extras)) > +all-nonlib := $(strip $(others) $(others-extras)) > ifneq (,$(all-nonlib)) > cpp-srcs-left = $(all-nonlib) > lib := nonlib > include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left)) > endif > > +# All internal tests use testsuite-internal module since for 64 bit time > +# support is set as default for MODULE_NAME=nonlib (which include some > +# installed programs. Missing close paren. > diff --git a/locale/localeinfo.h b/locale/localeinfo.h > index b3d4da0185..9e53681829 100644 > --- a/locale/localeinfo.h > +++ b/locale/localeinfo.h > @@ -50,7 +50,7 @@ struct __locale_data > { > const char *name; > const char *filedata; /* Region mapping the file data. */ > - off_t filesize; /* Size of the file (and the region). */ > + __off_t filesize; /* Size of the file (and the region). */ Why is that needed? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."