From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A4D193857406 for ; Tue, 1 Jun 2021 12:41:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4D193857406 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-glTWfg6_Pnm4oVbyPrhyKw-1; Tue, 01 Jun 2021 08:41:19 -0400 X-MC-Unique: glTWfg6_Pnm4oVbyPrhyKw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1FC58A0768; Tue, 1 Jun 2021 12:41:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 039B45D6D5; Tue, 1 Jun 2021 12:41:17 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v2 8/9] nptl: Use pthread_kill on pthread_cancel References: <20210527172823.3461314-1-adhemerval.zanella@linaro.org> <20210527172823.3461314-9-adhemerval.zanella@linaro.org> Date: Tue, 01 Jun 2021 14:41:16 +0200 In-Reply-To: <20210527172823.3461314-9-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 27 May 2021 14:28:22 -0300") Message-ID: <87fsy169lf.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 12:41:22 -0000 * Adhemerval Zanella via Libc-alpha: > It consolidates the tgkill call and it is the first step of making > pthread_cancel async-signal-safe. It also fix a possible issue > where the 'struct pthread' tid is not read atomically, which might > send an invalid cancellation signal (similar to what > db988e50a87f613cb6b9e98a2fc66a4848bc3546 fixed for pthread_join). Looks okay to me, thanks. Florian