From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 74B193857C6F for ; Tue, 11 May 2021 17:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 74B193857C6F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-138-psnbUQ89MAyd8Sn4DPuiMg-1; Tue, 11 May 2021 13:38:24 -0400 X-MC-Unique: psnbUQ89MAyd8Sn4DPuiMg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A37378014D8; Tue, 11 May 2021 17:38:23 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C992318024; Tue, 11 May 2021 17:38:22 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 7/9] nptl: Move pthread_attr_setstack into libc References: <5064d045f07070d2c20d24f4894976dbf80edc29.1620662729.git.fweimer@redhat.com> <87o8dhxjuk.fsf@oldenburg.str.redhat.com> <0a03570f-894e-6109-48da-7d3895506815@linaro.org> Date: Tue, 11 May 2021 19:38:50 +0200 In-Reply-To: <0a03570f-894e-6109-48da-7d3895506815@linaro.org> (Adhemerval Zanella's message of "Tue, 11 May 2021 14:35:56 -0300") Message-ID: <87fsytxj9x.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 17:38:27 -0000 * Adhemerval Zanella: > On 11/05/2021 14:26, Florian Weimer wrote: >> * Adhemerval Zanella: >>=20 >>>> +# endif /* OTHER_SHLIB_COMPAT */ >>>> +#endif /* PTHREAD_STACK_MIN !=3D 16384 */ >>> >>> Double space before '*/'. >>=20 >> I don't think the double-space rule applies here. It's =E2=80=9D. */= =E2=80=9D, but >> these comments referencing expressions etc. generally do not end in a >> dot in existing code. > > My impression is to always use a double space before comments ending, > regardless the sentence ending with a period or not (as least this is > the usual take I see in preprocessor comments like this). There's a majority for one space I think: $ git grep -E '/\* [a-zA-Z_]+ \*/' | wc -l 1666 $ git grep -E '/\* [a-zA-Z_]+ \*/' | wc -l 184 Thanks, Florian