From: Florian Weimer <fw@deneb.enyo.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "zhuyan \(M\)" <zhuyan34@huawei.com>,
"libc-alpha\@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] memcpy: use bhs/bls instead of bge/blt [BZ #25620]
Date: Tue, 28 Apr 2020 23:14:51 +0200 [thread overview]
Message-ID: <87ftcn48j8.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2004212126110.12411@digraph.polyomino.org.uk> (Joseph Myers's message of "Tue, 21 Apr 2020 21:27:25 +0000")
* Joseph Myers:
> On Tue, 21 Apr 2020, Florian Weimer wrote:
>
>> * Joseph Myers:
>>
>> > On Mon, 13 Apr 2020, zhuyan (M) wrote:
>> >
>> >> In ARMv7, the memcpy() implementation allows for program execution to
>> >> continue in scenarios where a segmentation fault or crash should have
>> >> occurred. The dangers occur in that subsequent execution and iterations
>> >> of this code will be executed with this corrupted data.
>> >>
>> >> Such as, we use 'memcpy' copy 0x80000000 byte to buffer(The buffer size
>> >> is 100 bytes), it didn't crash.
>> >
>> > This patch includes an architecture-specific test, specific to memcpy.
>> > My understanding of Wilco's request in bug 25620 was for an
>> > architecture-independent test or tests, covering all string functions with
>> > such large arguments, so we can ensure we're consistent across
>> > architectures.
>>
>> Sure, that would be great, but can we make this independent of this
>> fix, please?
>
> I think the minimum for this fix should be an architecture-independent
> test for memcpy (but not other string functions, and not necessarily
> testing all IFUNC variants of memcpy).
Fair enough. I'll try to write one using the RAM compression feature
I added. But I can't get a 32-bit Arm machine from the labs at work
right now, and it may be a while until I get a device delivered, so it
will be at least a few days more until I have a test that's been
confirmed to reproduce the bug.
next prev parent reply other threads:[~2020-04-28 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 14:16 zhuyan (M)
2020-04-14 22:26 ` Joseph Myers
2020-04-21 14:36 ` Florian Weimer
2020-04-21 21:27 ` Joseph Myers
2020-04-28 21:14 ` Florian Weimer [this message]
2020-04-30 20:33 ` Florian Weimer
2020-04-30 20:22 ` Florian Weimer
2020-04-15 11:59 Wilco Dijkstra
2020-05-01 12:58 Wilco Dijkstra
2020-05-06 12:40 zhuyan (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcn48j8.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zhuyan34@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).